commit 3dca91b84002f22f69ad5b9ddda0ce3579c4135b
author Georgios Pinitas <georgios.pinitas@arm.com> Tue Apr 13 13:35:58 2021 +0100
committer Georgios Pinitas <georgios.pinitas@arm.com> Tue Apr 13 15:44:46 2021 +0000
tree 4ca1bfb47525953ca6b541e217fac68df174fa3d
parent 21fda6ffee167d4f84a6976dfd94a711fb17a342

Disallow padding addittion when operating on CL images

Importing buffer to OpenCL images requires compliance to strict HW
requirements. Thus, disabling testing implicit padding when importing
buffer to image.

Resolves: COMPMID-4368

Signed-off-by: Georgios Pinitas <georgios.pinitas@arm.com>
Change-Id: Ib75499040b6dc02b435125674dc2cc91eacbf7ba
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/5416
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>

tests/validation/fixtures/GEMMFixture.h

diff --git a/tests/validation/fixtures/GEMMFixture.h b/tests/validation/fixtures/GEMMFixture.h
index 45516d4..868eed4 100644
--- a/tests/validation/fixtures/GEMMFixture.h
+++ b/tests/validation/fixtures/GEMMFixture.h
@@ -489,7 +489,7 @@
         ARM_COMPUTE_EXPECT(rhs.info()->is_resizable(), framework::LogLevel::ERRORS);
         ARM_COMPUTE_EXPECT(bias.info()->is_resizable(), framework::LogLevel::ERRORS);
 
-        // TODO: remove if statement after COMPMID-4368
+        // We do not pad when using image as it needs to comply to strict pitch alignment restrictions
         if(!rhs_info.export_to_cl_image)
         {
             add_padding_x({ &lhs, &rhs, &lhs_reshaped, &rhs_reshaped, &bias, &dst });
@@ -637,7 +637,7 @@
         ARM_COMPUTE_EXPECT(rhs.info()->is_resizable(), framework::LogLevel::ERRORS);
         ARM_COMPUTE_EXPECT(bias.info()->is_resizable(), framework::LogLevel::ERRORS);
 
-        // TODO: remove if statement after COMPMID-4368
+        // We do not pad when using image as it needs to comply to strict pitch alignment restrictions
         if(!rhs_info.export_to_cl_image)
         {
             add_padding_x({ &lhs, &rhs, &lhs_reshaped, &rhs_reshaped, &bias, &dst });
@@ -805,7 +805,7 @@
         ARM_COMPUTE_EXPECT(rhs.info()->is_resizable(), framework::LogLevel::ERRORS);
         ARM_COMPUTE_EXPECT(bias.info()->is_resizable(), framework::LogLevel::ERRORS);
 
-        // TODO: remove if statement after COMPMID-4368
+        // We do not pad when using image as it needs to comply to strict pitch alignment restrictions
         if(!rhs_info.export_to_cl_image)
         {
             add_padding_x({ &lhs, &rhs, &lhs_reshaped, &rhs_reshaped, &bias, &dst });
@@ -979,7 +979,7 @@
         ARM_COMPUTE_EXPECT(rhs.info()->is_resizable(), framework::LogLevel::ERRORS);
         ARM_COMPUTE_EXPECT(bias.info()->is_resizable(), framework::LogLevel::ERRORS);
 
-        // TODO: remove if statement after COMPMID-4368
+        // We do not pad when using image as it needs to comply to strict pitch alignment restrictions
         if(!rhs_info.export_to_cl_image)
         {
             add_padding_x({ &lhs, &rhs, &lhs_reshaped, &rhs_reshaped, &bias, &dst });
@@ -1148,7 +1148,7 @@
         ARM_COMPUTE_EXPECT(rhs.info()->is_resizable(), framework::LogLevel::ERRORS);
         ARM_COMPUTE_EXPECT(bias.info()->is_resizable(), framework::LogLevel::ERRORS);
 
-        // TODO: remove if statement after COMPMID-4368
+        // We do not pad when using image as it needs to comply to strict pitch alignment restrictions
         if(!rhs_info.export_to_cl_image)
         {
             add_padding_x({ &lhs, &rhs, &rhs_reshaped, &bias, &dst });
@@ -1313,7 +1313,7 @@
         ARM_COMPUTE_EXPECT(rhs.info()->is_resizable(), framework::LogLevel::ERRORS);
         ARM_COMPUTE_EXPECT(bias.info()->is_resizable(), framework::LogLevel::ERRORS);
 
-        // TODO: remove if statement after COMPMID-4368
+        // We do not pad when using image as it needs to comply to strict pitch alignment restrictions
         if(!rhs_info.export_to_cl_image)
         {
             add_padding_x({ &lhs, &rhs, &rhs_reshaped, &bias, &dst });