COMPMID-1451: Remove invalid bias inclusion in specialized function.
Fixed Segfault by removing bias iterator from specialized function which assumes no bias
being provided.
Change-Id: Ic897435ee9427d4359e8ab989a03e951da0d7ce0
Reviewed-on: https://review.mlplatform.org/314
Reviewed-by: Anthony Barbier <Anthony.barbier@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
diff --git a/src/core/NEON/kernels/NEDirectConvolutionLayerOutputStageKernel.cpp b/src/core/NEON/kernels/NEDirectConvolutionLayerOutputStageKernel.cpp
index d3ab549..09836f1 100644
--- a/src/core/NEON/kernels/NEDirectConvolutionLayerOutputStageKernel.cpp
+++ b/src/core/NEON/kernels/NEDirectConvolutionLayerOutputStageKernel.cpp
@@ -431,21 +431,13 @@
uint8x16_t min = vdupq_n_u8(0);
uint8x16_t max = vdupq_n_u8(255);
- Window window_bias = window;
- window_bias.set(Window::DimY, Window::Dimension(0, 0, 0));
- window_bias.set(Window::DimZ, Window::Dimension(0, 0, 0));
- window_bias.set(3, Window::Dimension(0, 0, 0));
-
Iterator in(input, window);
- Iterator bi(bias, window_bias);
-
Iterator out(output, window);
execute_window_loop(window, [&](const Coordinates & id)
{
- // Get bias and pointer to input
+ // Get pointer to input
const auto in_ptr = reinterpret_cast<int32_t *>(in.ptr());
- // Accumulate bias
int32x4x4_t v_in =
{
{
@@ -459,7 +451,7 @@
const auto out_ptr = out.ptr();
vst1q_u8(out_ptr, finalize_quantization<false>(v_in, result_fixedpoint_multiplier, result_shift, result_offset_after_shift_s32, min, max));
},
- in, bi, out);
+ in, out);
}
} // namespace