commit 9fc3be6250964a2da74cb7a05cf8e352a896ac80
author Georgios Pinitas <georgios.pinitas@arm.com> Sat May 29 04:01:51 2021 +0100
committer Georgios Pinitas <georgios.pinitas@arm.com> Tue Jun 01 16:16:45 2021 +0000
tree cdfeb80dfb556fb05851a8bb36377dcd3a808256
parent b4bb6a03f717a320b935809fde795b3d6ec5a69f

Fuse activation in ClDirectConv2dKernel for float types

Resolves:  COMPMID-4430

Signed-off-by: Georgios Pinitas <georgios.pinitas@arm.com>
Change-Id: I9a40033e09223d601460a7e52cc297c58c9a2737
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/5757
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>

src/runtime/gpu/cl/operators/ClDirectConv2d.cpp

diff --git a/src/runtime/gpu/cl/operators/ClDirectConv2d.cpp b/src/runtime/gpu/cl/operators/ClDirectConv2d.cpp
index 527b3a6..13ef42a 100644
--- a/src/runtime/gpu/cl/operators/ClDirectConv2d.cpp
+++ b/src/runtime/gpu/cl/operators/ClDirectConv2d.cpp
@@ -47,10 +47,13 @@
 void ClDirectConv2d::configure(const CLCompileContext &compile_context, ITensorInfo *src, ITensorInfo *weights, ITensorInfo *biases, ITensorInfo *dst,
                                const PadStrideInfo &conv_info, const ActivationLayerInfo &act_info)
 {
+    ARM_COMPUTE_ERROR_ON_NULLPTR(src);
+
     // Configure direct convolution kernel
-    auto k = std::make_unique<kernels::ClDirectConv2dKernel>();
+    const ActivationLayerInfo conv2d_act_info = (src->data_layout() == DataLayout::NHWC && is_data_type_float(src->data_type())) ? act_info : ActivationLayerInfo();
+    auto                      k               = std::make_unique<kernels::ClDirectConv2dKernel>();
     k->set_target(CLScheduler::get().target());
-    k->configure(compile_context, src, weights, biases, dst, conv_info);
+    k->configure(compile_context, src, weights, biases, dst, conv_info, conv2d_act_info);
     _direct_conv_kernel = std::move(k);
 
     // Configure border handler
@@ -63,7 +66,8 @@
     b->configure(compile_context, src, _direct_conv_kernel->border_size(), BorderMode::CONSTANT, zero_value);
     _src_border_handler = std::move(b);
 
-    if(act_info.enabled())
+    // Fused activation is currently supported for NHWC and floating point types
+    if(act_info.enabled() && !conv2d_act_info.enabled())
     {
         auto a = std::make_unique<kernels::ClActivationKernel>();
         a->configure(compile_context, dst, dst, act_info);
@@ -77,7 +81,7 @@
 Status ClDirectConv2d::validate(const ITensorInfo *src, const ITensorInfo *weights, const ITensorInfo *biases, const ITensorInfo *dst,
                                 const PadStrideInfo &conv_info, const ActivationLayerInfo &act_info)
 {
-    ARM_COMPUTE_RETURN_ON_ERROR(kernels::ClDirectConv2dKernel::validate(src, weights, biases, dst, conv_info, CLScheduler::get().target()));
+    ARM_COMPUTE_RETURN_ON_ERROR(kernels::ClDirectConv2dKernel::validate(src, weights, biases, dst, conv_info, ActivationLayerInfo(), CLScheduler::get().target()));
     if(act_info.enabled())
     {
         ARM_COMPUTE_RETURN_ON_ERROR(kernels::ClActivationKernel::validate(dst, dst, act_info));