commit ee939fb58e3fc50ae7c92c895f8abd1dd9f20eb3
author Luca Foschiani <luca.foschiani@arm.com> Tue Jan 28 10:38:07 2020 +0000
committer Luca Foschiani <luca.foschiani@arm.com> Wed Feb 26 09:39:08 2020 +0000
tree fd199008e32f95390270010cf3d449745abae3b8
parent ca8c0f79a9fc1b3056c574bdd134748ea3cfd885

COMPMID-2774: Add support for QASYMM8_SIGNED in NEReductionOperation, NEReduceMean and NEArgMinMaxLayer

Signed-off-by: Luca Foschiani <luca.foschiani@arm.com>
Change-Id: Icf198a983c8ce2c6cd8451a1190bb99115eac3af
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/2652
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Reviewed-by: Giorgio Arena <giorgio.arena@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>

tests/validation/fixtures/ReductionOperationFixture.h

diff --git a/tests/validation/fixtures/ReductionOperationFixture.h b/tests/validation/fixtures/ReductionOperationFixture.h
index 2802cd4..a93bf49 100644
--- a/tests/validation/fixtures/ReductionOperationFixture.h
+++ b/tests/validation/fixtures/ReductionOperationFixture.h
@@ -61,22 +61,31 @@
     template <typename U>
     void fill(U &&tensor)
     {
-        if(tensor.data_type() == DataType::QASYMM8)
+        if(!is_data_type_quantized(tensor.data_type()))
         {
-            std::pair<int, int> bounds = get_quantized_bounds(tensor.quantization_info(), -1.0f, 1.0f);
-            std::uniform_int_distribution<uint8_t> distribution(bounds.first, bounds.second);
-            library->fill(tensor, distribution, 0);
-        }
-        else if(tensor.data_type() == DataType::QASYMM8_SIGNED)
-        {
-            std::pair<int, int> bounds = get_quantized_qasymm8_signed_bounds(tensor.quantization_info(), -1.0f, 1.0f);
-            std::uniform_int_distribution<int8_t> distribution(bounds.first, bounds.second);
+            std::uniform_real_distribution<> distribution(-1.0f, 1.0f);
             library->fill(tensor, distribution, 0);
         }
         else
         {
-            std::uniform_real_distribution<> distribution(-1.0f, 1.0f);
-            library->fill(tensor, distribution, 0);
+            if(tensor.data_type() == DataType::QASYMM8)
+            {
+                std::pair<int, int> bounds = get_quantized_bounds(tensor.quantization_info(), -1.0f, 1.0f);
+                std::uniform_int_distribution<uint8_t> distribution(bounds.first, bounds.second);
+
+                library->fill(tensor, distribution, 0);
+            }
+            else if(tensor.data_type() == DataType::QASYMM8_SIGNED)
+            {
+                std::pair<int, int> bounds = get_quantized_qasymm8_signed_bounds(tensor.quantization_info(), -1.0f, 1.0f);
+                std::uniform_int_distribution<int8_t> distribution(bounds.first, bounds.second);
+
+                library->fill(tensor, distribution, 0);
+            }
+            else
+            {
+                ARM_COMPUTE_ERROR("Not supported");
+            }
         }
     }