commit f52cd78acdedc9b4e2342daf2ca65578a6da28e1
author Georgios Pinitas <georgios.pinitas@arm.com> Mon Mar 25 14:06:14 2019 +0000
committer Georgios Pinitas <georgios.pinitas@arm.com> Wed Mar 27 15:49:14 2019 +0000
tree 85850cc536a4360668a8a6185f691065fdb66c00
parent 8cf8c1123440c2002ee108d1949529bf21eac944

COMPMID-1995: Minor code fixes.

-Remove FIXMEs and link to tickets.
-Pass large object by const reference.
-Implement copy assignment operator for Window.

Change-Id: I975223ac42ec424f153569a8c963f29e6b86ad29
Signed-off-by: Georgios Pinitas <georgios.pinitas@arm.com>
Reviewed-on: https://review.mlplatform.org/c/899
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>

src/graph/GraphBuilder.cpp

diff --git a/src/graph/GraphBuilder.cpp b/src/graph/GraphBuilder.cpp
index 3f40aea..b96a242 100644
--- a/src/graph/GraphBuilder.cpp
+++ b/src/graph/GraphBuilder.cpp
@@ -369,7 +369,7 @@
 
     return conv_nid;
 }
-NodeID GraphBuilder::add_detection_output_node(Graph &g, NodeParams params, NodeIdxPair input_loc, NodeIdxPair input_conf, NodeIdxPair input_priorbox, DetectionOutputLayerInfo detect_info)
+NodeID GraphBuilder::add_detection_output_node(Graph &g, NodeParams params, NodeIdxPair input_loc, NodeIdxPair input_conf, NodeIdxPair input_priorbox, const DetectionOutputLayerInfo &detect_info)
 {
     CHECK_NODEIDX_PAIR(input_loc, g);
     CHECK_NODEIDX_PAIR(input_conf, g);
@@ -544,7 +544,7 @@
     return create_simple_single_input_output_node<PoolingLayerNode>(g, params, input, pool_info);
 }
 
-NodeID GraphBuilder::add_priorbox_node(Graph &g, NodeParams params, NodeIdxPair input0, NodeIdxPair input1, PriorBoxLayerInfo prior_info)
+NodeID GraphBuilder::add_priorbox_node(Graph &g, NodeParams params, NodeIdxPair input0, NodeIdxPair input1, const PriorBoxLayerInfo &prior_info)
 {
     CHECK_NODEIDX_PAIR(input0, g);
     CHECK_NODEIDX_PAIR(input1, g);