commit 09ad6f909f25aef02b7f53bba320b534b9260786
author Finn Williams <Finn.Williams@arm.com> Thu Dec 19 17:05:18 2019 +0000
committer Finn Williams <Finn.Williams@arm.com> Tue Jan 14 12:39:05 2020 +0000
tree e69f6d9d4b15b0c7e106c5f6749dd77586247a75
parent f90c56d72de4848a2dc5844a97458aaf09df07c2

IVGCVSW-4229 Fix Intermittent failures in ExternalProfiling

 * Added a BufferManager.Reset() method to prevent packets being retained after a test
 * Fixed a bug causing the send thread to wait needlessly before moving to active state
 * Refactored SendCoundPacketTests and ProfilingTests test helper classes
 * Fixed issue where WaitForPacketSent could miss a notification and timeout

Signed-off-by: Finn Williams <Finn.Williams@arm.com>
Change-Id: I353a652260c2f7dd465baa9e979e22f50f3ca6a7

src/profiling/ProfilingService.hpp

diff --git a/src/profiling/ProfilingService.hpp b/src/profiling/ProfilingService.hpp
index 746edb8..24748bb 100644
--- a/src/profiling/ProfilingService.hpp
+++ b/src/profiling/ProfilingService.hpp
@@ -206,7 +206,7 @@
     {
         instance.m_StateMachine.TransitionToState(newState);
     }
-    void WaitForPacketSent(ProfilingService& instance, uint32_t timeout = 1000)
+    bool WaitForPacketSent(ProfilingService& instance, uint32_t timeout = 1000)
     {
         return instance.m_SendCounterPacket.WaitForPacketSent(timeout);
     }