commit 18e6f04232b8aecaec9a232057ac3cb16e4f56f5
author Colm Donelan <colm.donelan@arm.com> Tue Jan 24 22:10:12 2023 +0000
committer Colm Donelan <colm.donelan@arm.com> Wed Jan 25 11:28:42 2023 +0000
tree 87144020143756a5ff496eccca6f79075b5e29bb
parent 04d8229bb3e78d1b1dd21eed41e47aabc25d8e2f

IVGCVSW-7441 Fixing null pointers in ExecuteNetwork.

* Check if BuildExecutor returns null in ExecuteNetwork.
* Check if tflite BuildFromFile returns null in TfliteExecutor.

Signed-off-by: Colm Donelan <colm.donelan@arm.com>
Change-Id: I42b6e5f26dfd127dd16b6b322184900846317c41

tests/ExecuteNetwork/ExecuteNetwork.cpp

diff --git a/tests/ExecuteNetwork/ExecuteNetwork.cpp b/tests/ExecuteNetwork/ExecuteNetwork.cpp
index c6c8cc0..a70f33f 100644
--- a/tests/ExecuteNetwork/ExecuteNetwork.cpp
+++ b/tests/ExecuteNetwork/ExecuteNetwork.cpp
@@ -1,5 +1,5 @@
 //
-// Copyright © 2022 Arm Ltd and Contributors. All rights reserved.
+// Copyright © 2022-2023 Arm Ltd and Contributors. All rights reserved.
 // SPDX-License-Identifier: MIT
 //
 
@@ -20,7 +20,7 @@
         return std::make_unique<TfLiteExecutor>(programOptions.m_ExNetParams);
 #else
         ARMNN_LOG(fatal) << "Not built with Arm NN Tensorflow-Lite delegate support.";
-            return nullptr;
+        return nullptr;
 #endif
     }
     else
@@ -59,7 +59,7 @@
     try
     {
         executor = BuildExecutor(programOptions);
-        if (executor->m_constructionFailed)
+        if ((!executor) || (executor->m_constructionFailed))
         {
             return EXIT_FAILURE;
         }

tests/ExecuteNetwork/TfliteExecutor.cpp

diff --git a/tests/ExecuteNetwork/TfliteExecutor.cpp b/tests/ExecuteNetwork/TfliteExecutor.cpp
index 6a79954..810495f 100644
--- a/tests/ExecuteNetwork/TfliteExecutor.cpp
+++ b/tests/ExecuteNetwork/TfliteExecutor.cpp
@@ -8,7 +8,10 @@
 TfLiteExecutor::TfLiteExecutor(const ExecuteNetworkParams& params) : m_Params(params)
 {
     m_Model = tflite::FlatBufferModel::BuildFromFile(m_Params.m_ModelPath.c_str());
-
+    if (!m_Model)
+    {
+        LogAndThrow("Failed to load TfLite model from: " + m_Params.m_ModelPath);
+    }
     m_TfLiteInterpreter =  std::make_unique<Interpreter>();
     tflite::ops::builtin::BuiltinOpResolver resolver;