commit 1dd75b3ce83b9adf611116d9247f7860951d8ed9
author Derek Lamberti <derek.lamberti@arm.com> Tue Dec 10 21:23:23 2019 +0000
committer Francis Murtagh <francis.murtagh@arm.com> Tue Dec 31 11:54:46 2019 +0000
tree 6e4ec4003730a70720d509ada5022b80b8217e07
parent 859f9ced8360fcfe6daedf6c8f6613005893f814

IVGCVSW-4246 Clean build profiling with -Wextra

Change-Id: Ieab870fa2194075433a0a26abdb13f69e1fbaaae
Signed-off-by: Derek Lamberti <derek.lamberti@arm.com>

src/profiling/test/SendCounterPacketTests.hpp

diff --git a/src/profiling/test/SendCounterPacketTests.hpp b/src/profiling/test/SendCounterPacketTests.hpp
index 79ebcd6..d0b13b5 100644
--- a/src/profiling/test/SendCounterPacketTests.hpp
+++ b/src/profiling/test/SendCounterPacketTests.hpp
@@ -67,13 +67,15 @@
 
     Packet ReadPacket(uint32_t timeout) override
     {
+        boost::ignore_unused(timeout);
+
         // Simulate a delay in the reading process. The default timeout is way too long.
         std::this_thread::sleep_for(std::chrono::milliseconds(5));
         std::lock_guard<std::mutex> lock(m_Mutex);
         return std::move(m_Packet);
     }
 
-    const std::vector<uint32_t> GetWrittenData()
+    std::vector<uint32_t> GetWrittenData()
     {
         std::lock_guard<std::mutex> lock(m_Mutex);
 
@@ -82,7 +84,7 @@
         return writtenData;
     }
 
-    const bool HasWrittenData()
+    bool HasWrittenData() const
     {
         std::lock_guard<std::mutex> lock(m_Mutex);
         return !m_WrittenData.empty();
@@ -107,6 +109,7 @@
 public:
     IProfilingConnectionPtr GetProfilingConnection(const ExternalProfilingOptions& options) const override
     {
+        boost::ignore_unused(options);
         return std::make_unique<MockProfilingConnection>();
     }
 };
@@ -295,6 +298,8 @@
 
     void SendCounterDirectoryPacket(const ICounterDirectory& counterDirectory) override
     {
+        boost::ignore_unused(counterDirectory);
+
         std::string message("SendCounterDirectoryPacket");
         unsigned int reserved = 0;
         IPacketBufferPtr buffer = m_BufferManager.Reserve(1024, reserved);
@@ -305,6 +310,8 @@
     void SendPeriodicCounterCapturePacket(uint64_t timestamp,
                                           const std::vector<std::pair<uint16_t, uint32_t>>& values) override
     {
+        boost::ignore_unused(timestamp, values);
+
         std::string message("SendPeriodicCounterCapturePacket");
         unsigned int reserved = 0;
         IPacketBufferPtr buffer = m_BufferManager.Reserve(1024, reserved);
@@ -315,6 +322,8 @@
     void SendPeriodicCounterSelectionPacket(uint32_t capturePeriod,
                                             const std::vector<uint16_t>& selectedCounterIds) override
     {
+        boost::ignore_unused(capturePeriod, selectedCounterIds);
+
         std::string message("SendPeriodicCounterSelectionPacket");
         unsigned int reserved = 0;
         IPacketBufferPtr buffer = m_BufferManager.Reserve(1024, reserved);
@@ -515,16 +524,19 @@
 
     const Device* GetDevice(uint16_t uid) const override
     {
+        boost::ignore_unused(uid);
         return nullptr; // Not used by the unit tests
     }
 
     const CounterSet* GetCounterSet(uint16_t uid) const override
     {
+        boost::ignore_unused(uid);
         return nullptr; // Not used by the unit tests
     }
 
     const Counter* GetCounter(uint16_t uid) const override
     {
+        boost::ignore_unused(uid);
         return nullptr; // Not used by the unit tests
     }