commit 35c31c04a9805082be32474211dcd62b7629ed2b
author Rob Hughes <robert.hughes@arm.com> Mon Aug 17 15:47:20 2020 +0100
committer TeresaARM <teresa.charlinreyes@arm.com> Mon Aug 17 17:35:13 2020 +0000
tree 69acbe73bb18a235d34e3acf256f84b3633f595a
parent ec01fb79f15de76f41bd74fac09c2ffb25b7ada6

Fix Windows build

Change-Id: I145d220c73313e31c184b6a75ab7f4823df99919
Signed-off-by: Robert Hughes <robert.hughes@arm.com>

cmake/GlobalConfig.cmake

diff --git a/cmake/GlobalConfig.cmake b/cmake/GlobalConfig.cmake
index e5a5866..b093e5d 100644
--- a/cmake/GlobalConfig.cmake
+++ b/cmake/GlobalConfig.cmake
@@ -347,7 +347,7 @@
 
 # This is the root for the dynamic backend tests to search for dynamic
 # backends. By default it will be the project build directory.
-add_definitions('-DDYNAMIC_BACKEND_BUILD_DIR="${PROJECT_BINARY_DIR}"')
+add_definitions(-DDYNAMIC_BACKEND_BUILD_DIR="${PROJECT_BINARY_DIR}")
 
 # ArmNN dynamic backend
 if(DYNAMIC_BACKEND_PATHS)

profiling/common/src/NetworkSockets.cpp

diff --git a/profiling/common/src/NetworkSockets.cpp b/profiling/common/src/NetworkSockets.cpp
index 2a65655..15ad087 100644
--- a/profiling/common/src/NetworkSockets.cpp
+++ b/profiling/common/src/NetworkSockets.cpp
@@ -8,17 +8,11 @@
 #if defined(__unix__) || defined(__APPLE__)
 #include <unistd.h>
 #include <fcntl.h>
-#include <common/include/Conversion.hpp>
 #endif
 
-#if defined(__APPLE__) || defined(_MSC_VER) || defined(__MINGW32__)
+#include <common/include/Conversion.hpp>
 #include <common/include/IgnoreUnused.hpp>
-#endif
-
-#if defined(__MINGW32__)
-#include <common/include/Conversion.hpp>
 #include <common/include/NumericCast.hpp>
-#endif
 
 namespace arm
 {

src/armnn/Logging.cpp

diff --git a/src/armnn/Logging.cpp b/src/armnn/Logging.cpp
index 8b46a77..0cdcdc5 100644
--- a/src/armnn/Logging.cpp
+++ b/src/armnn/Logging.cpp
@@ -9,7 +9,7 @@
 #include <armnn/utility/Assert.hpp>
 
 #if defined(_MSC_VER)
-#include <commons/include/WindowsWrapper.hpp>
+#include <common/include/WindowsWrapper.hpp>
 #endif
 
 #if defined(__ANDROID__)

src/armnn/test/UnitTests.cpp

diff --git a/src/armnn/test/UnitTests.cpp b/src/armnn/test/UnitTests.cpp
index 5d9211e..032a49f 100644
--- a/src/armnn/test/UnitTests.cpp
+++ b/src/armnn/test/UnitTests.cpp
@@ -24,7 +24,7 @@
 #include <boost/iostreams/filtering_stream.hpp>
 #include <boost/iostreams/tee.hpp>
 #include <iostream>
-#include <commons/include/WindowsWrapper.hpp>
+#include <common/include/WindowsWrapper.hpp>
 
 using namespace boost::iostreams;
 using namespace std;

src/armnnUtils/Filesystem.hpp

diff --git a/src/armnnUtils/Filesystem.hpp b/src/armnnUtils/Filesystem.hpp
index 3d93ce6..ba0d97a 100644
--- a/src/armnnUtils/Filesystem.hpp
+++ b/src/armnnUtils/Filesystem.hpp
@@ -5,6 +5,11 @@
 
 #pragma once
 
+#if defined(_MSC_VER)
+// ghc includes Windows.h directly, bringing in macros that we don't want (e.g. min/max).
+// By including Windows.h ourselves first (with appropriate options), we prevent this.
+#include <common/include/WindowsWrapper.hpp>
+#endif
 #include <ghc/filesystem.hpp>
 namespace fs = ghc::filesystem;
 

src/armnnUtils/Processes.cpp

diff --git a/src/armnnUtils/Processes.cpp b/src/armnnUtils/Processes.cpp
index eb68dd9..8b401d4 100644
--- a/src/armnnUtils/Processes.cpp
+++ b/src/armnnUtils/Processes.cpp
@@ -8,7 +8,7 @@
 #if defined(__unix__) || defined(__APPLE__)
 #include <unistd.h>
 #elif defined(_MSC_VER)
-#include <commons/include/WindowsWrapper.hpp>
+#include <common/include/WindowsWrapper.hpp>
 #endif
 
 namespace armnnUtils

src/armnnUtils/Threads.cpp

diff --git a/src/armnnUtils/Threads.cpp b/src/armnnUtils/Threads.cpp
index 3ee8174..64a8481 100644
--- a/src/armnnUtils/Threads.cpp
+++ b/src/armnnUtils/Threads.cpp
@@ -10,7 +10,7 @@
 #include <sys/syscall.h>
 #define gettid() syscall(SYS_gettid)
 #elif defined(_MSC_VER)
-#include <commons/include/WindowsWrapper.hpp>
+#include <common/include/WindowsWrapper.hpp>
 #elif defined(__APPLE__)
 #include "AvailabilityMacros.h"
 #include <sys/syscall.h>