commit 940932dd9b1fd6bbcca7d783906ee291608ef3f9
author Colm Donelan <colm.donelan@arm.com> Wed Jan 26 15:11:19 2022 +0000
committer Nikhil Raj Arm <nikhil.raj@arm.com> Wed Jan 26 16:33:48 2022 +0000
tree 9f2cb7c28ed67bd224e7ef77561910174178d8cd
parent 98b0dcb7f285f0009aee52cf526e4bfacd558d6d

IVGCVSW-6727 Change asserts to CHECK in ParserFlatbuffersFixture.hpp.

* ReadStringToBinary was using ARMNN_ASSERT_MSG which is hiding unit
  test errors in release builds.

Signed-off-by: Colm Donelan <colm.donelan@arm.com>
Change-Id: Ib5d6846525a3a1191f85004c7985773917a1f609

src/armnnTfLiteParser/test/ParserFlatbuffersFixture.hpp

diff --git a/src/armnnTfLiteParser/test/ParserFlatbuffersFixture.hpp b/src/armnnTfLiteParser/test/ParserFlatbuffersFixture.hpp
index 6b35558..e1e64c4 100644
--- a/src/armnnTfLiteParser/test/ParserFlatbuffersFixture.hpp
+++ b/src/armnnTfLiteParser/test/ParserFlatbuffersFixture.hpp
@@ -11,7 +11,6 @@
 #include <armnn/IRuntime.hpp>
 #include <armnn/TypesUtils.hpp>
 #include <armnn/BackendRegistry.hpp>
-#include <armnn/utility/Assert.hpp>
 
 #include "../TfLiteParser.hpp"
 
@@ -120,8 +119,8 @@
 
     void loadNetwork(armnn::NetworkId networkId, bool loadDynamic)
     {
-        bool ok = ReadStringToBinary();
-        if (!ok) {
+        if (!ReadStringToBinary())
+        {
             throw armnn::Exception("LoadNetwork failed while reading binary input");
         }
 
@@ -166,15 +165,10 @@
         flatbuffers::Parser parser;
 
         bool ok = parser.Parse(schemafile.c_str());
-        ARMNN_ASSERT_MSG(ok, "Failed to parse schema file");
+        CHECK_MESSAGE(ok, "Failed to parse schema file");
 
-        ok &= parser.Parse(m_JsonString.c_str());
-        ARMNN_ASSERT_MSG(ok, "Failed to parse json input");
-
-        if (!ok)
-        {
-            return false;
-        }
+        ok = parser.Parse(m_JsonString.c_str());
+        CHECK_MESSAGE(ok, "Failed to parse json input");
 
         {
             const uint8_t * bufferPtr = parser.builder_.GetBufferPointer();