Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 1 | // |
Jim Flynn | 6398a98 | 2020-05-27 17:05:21 +0100 | [diff] [blame] | 2 | // Copyright © 2019 Arm Ltd and Contributors. All rights reserved. |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 3 | // SPDX-License-Identifier: MIT |
| 4 | // |
| 5 | |
Jim Flynn | 6406355 | 2020-02-14 10:18:08 +0000 | [diff] [blame] | 6 | #include "ProfilingMocks.hpp" |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 7 | |
| 8 | #include <BufferManager.hpp> |
Jim Flynn | 00f3aaf | 2019-10-24 11:58:06 +0100 | [diff] [blame] | 9 | #include <ProfilingService.hpp> |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 10 | #include <ProfilingUtils.hpp> |
| 11 | #include <SendTimelinePacket.hpp> |
Jim Flynn | bbfe603 | 2020-07-20 16:57:44 +0100 | [diff] [blame] | 12 | #include <Threads.hpp> |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 13 | #include <TimelinePacketWriterFactory.hpp> |
| 14 | |
Jim Flynn | bbfe603 | 2020-07-20 16:57:44 +0100 | [diff] [blame] | 15 | #include <common/include/SwTrace.hpp> |
Nikhil Raj | 77fe76b | 2021-06-09 14:55:32 +0100 | [diff] [blame] | 16 | #include <common/include/LabelsAndEventClasses.hpp> |
Jim Flynn | bbfe603 | 2020-07-20 16:57:44 +0100 | [diff] [blame] | 17 | |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 18 | #include <doctest/doctest.h> |
Jim Flynn | ab84575 | 2019-10-25 13:17:30 +0100 | [diff] [blame] | 19 | |
| 20 | #include <functional> |
Keith Davis | 33ed221 | 2020-03-30 10:43:41 +0100 | [diff] [blame] | 21 | #include <Runtime.hpp> |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 22 | |
| 23 | using namespace armnn::profiling; |
| 24 | |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 25 | TEST_SUITE("SendTimelinePacketTests") |
| 26 | { |
| 27 | TEST_CASE("SendTimelineMessageDirectoryPackageTest") |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 28 | { |
| 29 | MockBufferManager mockBuffer(512); |
| 30 | TimelinePacketWriterFactory timelinePacketWriterFactory(mockBuffer); |
| 31 | std::unique_ptr<ISendTimelinePacket> sendTimelinePacket = timelinePacketWriterFactory.GetSendTimelinePacket(); |
| 32 | |
| 33 | sendTimelinePacket->SendTimelineMessageDirectoryPackage(); |
| 34 | |
| 35 | // Get the readable buffer |
| 36 | auto packetBuffer = mockBuffer.GetReadableBuffer(); |
| 37 | |
Matteo Martincigh | 34a407d | 2019-11-06 15:30:54 +0000 | [diff] [blame] | 38 | unsigned int uint8_t_size = sizeof(uint8_t); |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 39 | unsigned int uint32_t_size = sizeof(uint32_t); |
Matteo Martincigh | 34a407d | 2019-11-06 15:30:54 +0000 | [diff] [blame] | 40 | unsigned int uint64_t_size = sizeof(uint64_t); |
Matteo Martincigh | 34a407d | 2019-11-06 15:30:54 +0000 | [diff] [blame] | 41 | |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 42 | // Check the packet header |
| 43 | unsigned int offset = 0; |
| 44 | uint32_t packetHeaderWord0 = ReadUint32(packetBuffer, offset); |
| 45 | uint32_t packetFamily = (packetHeaderWord0 >> 26) & 0x0000003F; |
| 46 | uint32_t packetClass = (packetHeaderWord0 >> 19) & 0x0000007F; |
| 47 | uint32_t packetType = (packetHeaderWord0 >> 16) & 0x00000007; |
| 48 | uint32_t streamId = (packetHeaderWord0 >> 0) & 0x00000007; |
| 49 | |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 50 | CHECK(packetFamily == 1); |
| 51 | CHECK(packetClass == 0); |
| 52 | CHECK(packetType == 0); |
| 53 | CHECK(streamId == 0); |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 54 | |
| 55 | offset += uint32_t_size; |
| 56 | uint32_t packetHeaderWord1 = ReadUint32(packetBuffer, offset); |
| 57 | uint32_t sequenceNumbered = (packetHeaderWord1 >> 24) & 0x00000001; |
| 58 | uint32_t dataLength = (packetHeaderWord1 >> 0) & 0x00FFFFFF; |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 59 | CHECK(sequenceNumbered == 0); |
| 60 | CHECK(dataLength == 443); |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 61 | |
| 62 | offset += uint32_t_size; |
Matteo Martincigh | 34a407d | 2019-11-06 15:30:54 +0000 | [diff] [blame] | 63 | uint8_t readStreamVersion = ReadUint8(packetBuffer, offset); |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 64 | CHECK(readStreamVersion == 4); |
Matteo Martincigh | 34a407d | 2019-11-06 15:30:54 +0000 | [diff] [blame] | 65 | offset += uint8_t_size; |
| 66 | uint8_t readPointerBytes = ReadUint8(packetBuffer, offset); |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 67 | CHECK(readPointerBytes == uint64_t_size); |
Matteo Martincigh | 34a407d | 2019-11-06 15:30:54 +0000 | [diff] [blame] | 68 | offset += uint8_t_size; |
| 69 | uint8_t readThreadIdBytes = ReadUint8(packetBuffer, offset); |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 70 | CHECK(readThreadIdBytes == ThreadIdSize); |
Matteo Martincigh | 34a407d | 2019-11-06 15:30:54 +0000 | [diff] [blame] | 71 | |
| 72 | offset += uint8_t_size; |
Finn Williams | e63a026 | 2019-10-22 10:30:49 +0100 | [diff] [blame] | 73 | uint32_t DeclCount = ReadUint32(packetBuffer, offset); |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 74 | CHECK(DeclCount == 5); |
Finn Williams | e63a026 | 2019-10-22 10:30:49 +0100 | [diff] [blame] | 75 | |
| 76 | offset += uint32_t_size; |
Jim Flynn | bbfe603 | 2020-07-20 16:57:44 +0100 | [diff] [blame] | 77 | arm::pipe::SwTraceMessage swTraceMessage = arm::pipe::ReadSwTraceMessage(packetBuffer->GetReadableData(), |
| 78 | offset, |
| 79 | packetBuffer->GetSize()); |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 80 | |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 81 | CHECK(swTraceMessage.m_Id == 0); |
| 82 | CHECK(swTraceMessage.m_Name == "declareLabel"); |
| 83 | CHECK(swTraceMessage.m_UiName == "declare label"); |
| 84 | CHECK(swTraceMessage.m_ArgTypes.size() == 2); |
| 85 | CHECK(swTraceMessage.m_ArgTypes[0] == 'p'); |
| 86 | CHECK(swTraceMessage.m_ArgTypes[1] == 's'); |
| 87 | CHECK(swTraceMessage.m_ArgNames.size() == 2); |
| 88 | CHECK(swTraceMessage.m_ArgNames[0] == "guid"); |
| 89 | CHECK(swTraceMessage.m_ArgNames[1] == "value"); |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 90 | |
Jim Flynn | bbfe603 | 2020-07-20 16:57:44 +0100 | [diff] [blame] | 91 | swTraceMessage = arm::pipe::ReadSwTraceMessage(packetBuffer->GetReadableData(), |
| 92 | offset, |
| 93 | packetBuffer->GetSize()); |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 94 | |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 95 | CHECK(swTraceMessage.m_Id == 1); |
| 96 | CHECK(swTraceMessage.m_Name == "declareEntity"); |
| 97 | CHECK(swTraceMessage.m_UiName == "declare entity"); |
| 98 | CHECK(swTraceMessage.m_ArgTypes.size() == 1); |
| 99 | CHECK(swTraceMessage.m_ArgTypes[0] == 'p'); |
| 100 | CHECK(swTraceMessage.m_ArgNames.size() == 1); |
| 101 | CHECK(swTraceMessage.m_ArgNames[0] == "guid"); |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 102 | |
Jim Flynn | bbfe603 | 2020-07-20 16:57:44 +0100 | [diff] [blame] | 103 | swTraceMessage = arm::pipe::ReadSwTraceMessage(packetBuffer->GetReadableData(), |
| 104 | offset, |
| 105 | packetBuffer->GetSize()); |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 106 | |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 107 | CHECK(swTraceMessage.m_Id == 2); |
| 108 | CHECK(swTraceMessage.m_Name == "declareEventClass"); |
| 109 | CHECK(swTraceMessage.m_UiName == "declare event class"); |
| 110 | CHECK(swTraceMessage.m_ArgTypes.size() == 2); |
| 111 | CHECK(swTraceMessage.m_ArgTypes[0] == 'p'); |
| 112 | CHECK(swTraceMessage.m_ArgTypes[1] == 'p'); |
| 113 | CHECK(swTraceMessage.m_ArgNames.size() == 2); |
| 114 | CHECK(swTraceMessage.m_ArgNames[0] == "guid"); |
| 115 | CHECK(swTraceMessage.m_ArgNames[1] == "nameGuid"); |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 116 | |
Jim Flynn | bbfe603 | 2020-07-20 16:57:44 +0100 | [diff] [blame] | 117 | swTraceMessage = arm::pipe::ReadSwTraceMessage(packetBuffer->GetReadableData(), |
| 118 | offset, |
| 119 | packetBuffer->GetSize()); |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 120 | |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 121 | CHECK(swTraceMessage.m_Id == 3); |
| 122 | CHECK(swTraceMessage.m_Name == "declareRelationship"); |
| 123 | CHECK(swTraceMessage.m_UiName == "declare relationship"); |
| 124 | CHECK(swTraceMessage.m_ArgTypes.size() == 5); |
| 125 | CHECK(swTraceMessage.m_ArgTypes[0] == 'I'); |
| 126 | CHECK(swTraceMessage.m_ArgTypes[1] == 'p'); |
| 127 | CHECK(swTraceMessage.m_ArgTypes[2] == 'p'); |
| 128 | CHECK(swTraceMessage.m_ArgTypes[3] == 'p'); |
| 129 | CHECK(swTraceMessage.m_ArgTypes[4] == 'p'); |
| 130 | CHECK(swTraceMessage.m_ArgNames.size() == 5); |
| 131 | CHECK(swTraceMessage.m_ArgNames[0] == "relationshipType"); |
| 132 | CHECK(swTraceMessage.m_ArgNames[1] == "relationshipGuid"); |
| 133 | CHECK(swTraceMessage.m_ArgNames[2] == "headGuid"); |
| 134 | CHECK(swTraceMessage.m_ArgNames[3] == "tailGuid"); |
| 135 | CHECK(swTraceMessage.m_ArgNames[4] == "attributeGuid"); |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 136 | |
Jim Flynn | bbfe603 | 2020-07-20 16:57:44 +0100 | [diff] [blame] | 137 | swTraceMessage = arm::pipe::ReadSwTraceMessage(packetBuffer->GetReadableData(), |
| 138 | offset, |
| 139 | packetBuffer->GetSize()); |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 140 | |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 141 | CHECK(swTraceMessage.m_Id == 4); |
| 142 | CHECK(swTraceMessage.m_Name == "declareEvent"); |
| 143 | CHECK(swTraceMessage.m_UiName == "declare event"); |
| 144 | CHECK(swTraceMessage.m_ArgTypes.size() == 3); |
| 145 | CHECK(swTraceMessage.m_ArgTypes[0] == '@'); |
| 146 | CHECK(swTraceMessage.m_ArgTypes[1] == 't'); |
| 147 | CHECK(swTraceMessage.m_ArgTypes[2] == 'p'); |
| 148 | CHECK(swTraceMessage.m_ArgNames.size() == 3); |
| 149 | CHECK(swTraceMessage.m_ArgNames[0] == "timestamp"); |
| 150 | CHECK(swTraceMessage.m_ArgNames[1] == "threadId"); |
| 151 | CHECK(swTraceMessage.m_ArgNames[2] == "eventGuid"); |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 152 | } |
| 153 | |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 154 | TEST_CASE("SendTimelineEntityWithEventClassPacketTest") |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 155 | { |
| 156 | MockBufferManager bufferManager(40); |
| 157 | TimelinePacketWriterFactory timelinePacketWriterFactory(bufferManager); |
| 158 | std::unique_ptr<ISendTimelinePacket> sendTimelinePacket = timelinePacketWriterFactory.GetSendTimelinePacket(); |
| 159 | |
| 160 | const uint64_t entityBinaryPacketProfilingGuid = 123456u; |
| 161 | sendTimelinePacket->SendTimelineEntityBinaryPacket(entityBinaryPacketProfilingGuid); |
| 162 | |
| 163 | const uint64_t eventClassBinaryPacketProfilingGuid = 789123u; |
Jim Flynn | 1892d21 | 2020-05-26 21:10:49 +0100 | [diff] [blame] | 164 | const uint64_t eventClassBinaryPacketNameGuid = 8845u; |
| 165 | sendTimelinePacket->SendTimelineEventClassBinaryPacket( |
| 166 | eventClassBinaryPacketProfilingGuid, eventClassBinaryPacketNameGuid); |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 167 | |
| 168 | // Commit the messages |
| 169 | sendTimelinePacket->Commit(); |
| 170 | |
| 171 | // Get the readable buffer |
| 172 | auto packetBuffer = bufferManager.GetReadableBuffer(); |
| 173 | |
| 174 | unsigned int uint32_t_size = sizeof(uint32_t); |
| 175 | unsigned int uint64_t_size = sizeof(uint64_t); |
| 176 | |
| 177 | // Check the packet header |
| 178 | unsigned int offset = 0; |
| 179 | |
| 180 | // Reading TimelineEntityClassBinaryPacket |
Keith Davis | 97da5e2 | 2020-03-05 16:25:28 +0000 | [diff] [blame] | 181 | uint32_t entityBinaryPacketHeaderWord0 = ReadUint32(packetBuffer, offset); |
| 182 | uint32_t entityBinaryPacketFamily = (entityBinaryPacketHeaderWord0 >> 26) & 0x0000003F; |
| 183 | uint32_t entityBinaryPacketClass = (entityBinaryPacketHeaderWord0 >> 19) & 0x0000007F; |
| 184 | uint32_t entityBinaryPacketType = (entityBinaryPacketHeaderWord0 >> 16) & 0x00000007; |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 185 | uint32_t entityBinaryPacketStreamId = (entityBinaryPacketHeaderWord0 >> 0) & 0x00000007; |
| 186 | |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 187 | CHECK(entityBinaryPacketFamily == 1); |
| 188 | CHECK(entityBinaryPacketClass == 0); |
| 189 | CHECK(entityBinaryPacketType == 1); |
| 190 | CHECK(entityBinaryPacketStreamId == 0); |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 191 | |
| 192 | offset += uint32_t_size; |
Keith Davis | 97da5e2 | 2020-03-05 16:25:28 +0000 | [diff] [blame] | 193 | |
| 194 | uint32_t entityBinaryPacketHeaderWord1 = ReadUint32(packetBuffer, offset); |
| 195 | |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 196 | uint32_t entityBinaryPacketSequenceNumbered = (entityBinaryPacketHeaderWord1 >> 24) & 0x00000001; |
| 197 | uint32_t entityBinaryPacketDataLength = (entityBinaryPacketHeaderWord1 >> 0) & 0x00FFFFFF; |
Keith Davis | 97da5e2 | 2020-03-05 16:25:28 +0000 | [diff] [blame] | 198 | |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 199 | CHECK(entityBinaryPacketSequenceNumbered == 0); |
| 200 | CHECK(entityBinaryPacketDataLength == 32); |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 201 | |
| 202 | // Check the decl_id |
| 203 | offset += uint32_t_size; |
| 204 | uint32_t entitytDecId = ReadUint32(packetBuffer, offset); |
| 205 | |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 206 | CHECK(entitytDecId == uint32_t(1)); |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 207 | |
| 208 | // Check the profiling GUID |
| 209 | offset += uint32_t_size; |
| 210 | uint64_t readProfilingGuid = ReadUint64(packetBuffer, offset); |
| 211 | |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 212 | CHECK(readProfilingGuid == entityBinaryPacketProfilingGuid); |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 213 | |
| 214 | // Reading TimelineEventClassBinaryPacket |
| 215 | offset += uint64_t_size; |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 216 | |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 217 | uint32_t eventClassDeclId = ReadUint32(packetBuffer, offset); |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 218 | CHECK(eventClassDeclId == uint32_t(2)); |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 219 | |
| 220 | // Check the profiling GUID |
| 221 | offset += uint32_t_size; |
| 222 | readProfilingGuid = ReadUint64(packetBuffer, offset); |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 223 | CHECK(readProfilingGuid == eventClassBinaryPacketProfilingGuid); |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 224 | |
Jim Flynn | 1892d21 | 2020-05-26 21:10:49 +0100 | [diff] [blame] | 225 | offset += uint64_t_size; |
| 226 | uint64_t readEventClassNameGuid = ReadUint64(packetBuffer, offset); |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 227 | CHECK(readEventClassNameGuid == eventClassBinaryPacketNameGuid); |
Jim Flynn | 1892d21 | 2020-05-26 21:10:49 +0100 | [diff] [blame] | 228 | |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 229 | bufferManager.MarkRead(packetBuffer); |
| 230 | } |
| 231 | |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 232 | TEST_CASE("SendEventClassAfterTimelineEntityPacketTest") |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 233 | { |
| 234 | unsigned int uint32_t_size = sizeof(uint32_t); |
| 235 | unsigned int uint64_t_size = sizeof(uint64_t); |
| 236 | |
| 237 | MockBufferManager bufferManager(512); |
| 238 | TimelinePacketWriterFactory timelinePacketWriterFactory(bufferManager); |
| 239 | std::unique_ptr<ISendTimelinePacket> sendTimelinePacket = timelinePacketWriterFactory.GetSendTimelinePacket(); |
| 240 | |
| 241 | // Send TimelineEntityClassBinaryPacket |
| 242 | const uint64_t entityBinaryPacketProfilingGuid = 123456u; |
| 243 | sendTimelinePacket->SendTimelineEntityBinaryPacket(entityBinaryPacketProfilingGuid); |
| 244 | |
| 245 | // Commit the buffer |
| 246 | sendTimelinePacket->Commit(); |
| 247 | |
| 248 | // Get the readable buffer |
| 249 | auto packetBuffer = bufferManager.GetReadableBuffer(); |
| 250 | |
| 251 | // Check the packet header |
| 252 | unsigned int offset = 0; |
| 253 | |
| 254 | // Reading TimelineEntityClassBinaryPacket |
| 255 | uint32_t entityBinaryPacketHeaderWord0 = ReadUint32(packetBuffer, offset); |
| 256 | uint32_t entityBinaryPacketFamily = (entityBinaryPacketHeaderWord0 >> 26) & 0x0000003F; |
| 257 | uint32_t entityBinaryPacketClass = (entityBinaryPacketHeaderWord0 >> 19) & 0x0000007F; |
| 258 | uint32_t entityBinaryPacketType = (entityBinaryPacketHeaderWord0 >> 16) & 0x00000007; |
| 259 | uint32_t entityBinaryPacketStreamId = (entityBinaryPacketHeaderWord0 >> 0) & 0x00000007; |
| 260 | |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 261 | CHECK(entityBinaryPacketFamily == 1); |
| 262 | CHECK(entityBinaryPacketClass == 0); |
| 263 | CHECK(entityBinaryPacketType == 1); |
| 264 | CHECK(entityBinaryPacketStreamId == 0); |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 265 | |
| 266 | offset += uint32_t_size; |
| 267 | uint32_t entityBinaryPacketHeaderWord1 = ReadUint32(packetBuffer, offset); |
| 268 | uint32_t entityBinaryPacketSequenceNumbered = (entityBinaryPacketHeaderWord1 >> 24) & 0x00000001; |
| 269 | uint32_t entityBinaryPacketDataLength = (entityBinaryPacketHeaderWord1 >> 0) & 0x00FFFFFF; |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 270 | CHECK(entityBinaryPacketSequenceNumbered == 0); |
| 271 | CHECK(entityBinaryPacketDataLength == 12); |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 272 | |
| 273 | // Check the decl_id |
| 274 | offset += uint32_t_size; |
| 275 | uint32_t entitytDecId = ReadUint32(packetBuffer, offset); |
| 276 | |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 277 | CHECK(entitytDecId == uint32_t(1)); |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 278 | |
| 279 | // Check the profiling GUID |
| 280 | offset += uint32_t_size; |
| 281 | uint64_t readProfilingGuid = ReadUint64(packetBuffer, offset); |
| 282 | |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 283 | CHECK(readProfilingGuid == entityBinaryPacketProfilingGuid); |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 284 | |
| 285 | bufferManager.MarkRead(packetBuffer); |
| 286 | |
| 287 | // Send TimelineEventClassBinaryPacket |
| 288 | const uint64_t eventClassBinaryPacketProfilingGuid = 789123u; |
Jim Flynn | 1892d21 | 2020-05-26 21:10:49 +0100 | [diff] [blame] | 289 | const uint64_t eventClassBinaryPacketNameGuid = 8845u; |
| 290 | sendTimelinePacket->SendTimelineEventClassBinaryPacket( |
| 291 | eventClassBinaryPacketProfilingGuid, eventClassBinaryPacketNameGuid); |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 292 | |
| 293 | // Commit the buffer |
| 294 | sendTimelinePacket->Commit(); |
| 295 | |
| 296 | // Get the readable buffer |
| 297 | packetBuffer = bufferManager.GetReadableBuffer(); |
| 298 | |
| 299 | // Check the packet header |
| 300 | offset = 0; |
| 301 | |
| 302 | // Reading TimelineEventClassBinaryPacket |
| 303 | uint32_t eventClassBinaryPacketHeaderWord0 = ReadUint32(packetBuffer, offset); |
| 304 | uint32_t eventClassBinaryPacketFamily = (eventClassBinaryPacketHeaderWord0 >> 26) & 0x0000003F; |
| 305 | uint32_t eventClassBinaryPacketClass = (eventClassBinaryPacketHeaderWord0 >> 19) & 0x0000007F; |
| 306 | uint32_t eventClassBinaryPacketType = (eventClassBinaryPacketHeaderWord0 >> 16) & 0x00000007; |
| 307 | uint32_t eventClassBinaryPacketStreamId = (eventClassBinaryPacketHeaderWord0 >> 0) & 0x00000007; |
| 308 | |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 309 | CHECK(eventClassBinaryPacketFamily == 1); |
| 310 | CHECK(eventClassBinaryPacketClass == 0); |
| 311 | CHECK(eventClassBinaryPacketType == 1); |
| 312 | CHECK(eventClassBinaryPacketStreamId == 0); |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 313 | |
| 314 | offset += uint32_t_size; |
| 315 | uint32_t eventClassBinaryPacketHeaderWord1 = ReadUint32(packetBuffer, offset); |
| 316 | uint32_t eventClassBinaryPacketSequenceNumbered = (eventClassBinaryPacketHeaderWord1 >> 24) & 0x00000001; |
| 317 | uint32_t eventClassBinaryPacketDataLength = (eventClassBinaryPacketHeaderWord1 >> 0) & 0x00FFFFFF; |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 318 | CHECK(eventClassBinaryPacketSequenceNumbered == 0); |
| 319 | CHECK(eventClassBinaryPacketDataLength == 20); |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 320 | |
| 321 | offset += uint32_t_size; |
| 322 | uint32_t eventClassDeclId = ReadUint32(packetBuffer, offset); |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 323 | CHECK(eventClassDeclId == uint32_t(2)); |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 324 | |
| 325 | // Check the profiling GUID |
| 326 | offset += uint32_t_size; |
| 327 | readProfilingGuid = ReadUint64(packetBuffer, offset); |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 328 | CHECK(readProfilingGuid == eventClassBinaryPacketProfilingGuid); |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 329 | |
Jim Flynn | 1892d21 | 2020-05-26 21:10:49 +0100 | [diff] [blame] | 330 | offset += uint64_t_size; |
| 331 | uint64_t readEventClassNameGuid = ReadUint64(packetBuffer, offset); |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 332 | CHECK(readEventClassNameGuid == eventClassBinaryPacketNameGuid); |
Jim Flynn | 1892d21 | 2020-05-26 21:10:49 +0100 | [diff] [blame] | 333 | |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 334 | bufferManager.MarkRead(packetBuffer); |
| 335 | |
| 336 | // Send TimelineEventBinaryPacket |
| 337 | const uint64_t timestamp = 456789u; |
Jim Flynn | 1fdeb99 | 2020-07-09 07:28:37 +0100 | [diff] [blame] | 338 | const int threadId = armnnUtils::Threads::GetCurrentThreadId(); |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 339 | const uint64_t eventProfilingGuid = 123456u; |
| 340 | sendTimelinePacket->SendTimelineEventBinaryPacket(timestamp, threadId, eventProfilingGuid); |
| 341 | |
| 342 | // Commit the buffer |
| 343 | sendTimelinePacket->Commit(); |
| 344 | |
| 345 | // Get the readable buffer |
| 346 | packetBuffer = bufferManager.GetReadableBuffer(); |
| 347 | |
| 348 | // Check the packet header |
| 349 | offset = 0; |
| 350 | |
| 351 | // Reading TimelineEventBinaryPacket |
| 352 | uint32_t eventBinaryPacketHeaderWord0 = ReadUint32(packetBuffer, offset); |
| 353 | uint32_t eventBinaryPacketFamily = (eventBinaryPacketHeaderWord0 >> 26) & 0x0000003F; |
| 354 | uint32_t eventBinaryPacketClass = (eventBinaryPacketHeaderWord0 >> 19) & 0x0000007F; |
| 355 | uint32_t eventBinaryPacketType = (eventBinaryPacketHeaderWord0 >> 16) & 0x00000007; |
| 356 | uint32_t eventBinaryPacketStreamId = (eventBinaryPacketHeaderWord0 >> 0) & 0x00000007; |
| 357 | |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 358 | CHECK(eventBinaryPacketFamily == 1); |
| 359 | CHECK(eventBinaryPacketClass == 0); |
| 360 | CHECK(eventBinaryPacketType == 1); |
| 361 | CHECK(eventBinaryPacketStreamId == 0); |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 362 | |
| 363 | offset += uint32_t_size; |
| 364 | uint32_t eventBinaryPacketHeaderWord1 = ReadUint32(packetBuffer, offset); |
| 365 | uint32_t eventBinaryPacketSequenceNumbered = (eventBinaryPacketHeaderWord1 >> 24) & 0x00000001; |
| 366 | uint32_t eventBinaryPacketDataLength = (eventBinaryPacketHeaderWord1 >> 0) & 0x00FFFFFF; |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 367 | CHECK(eventBinaryPacketSequenceNumbered == 0); |
| 368 | CHECK(eventBinaryPacketDataLength == 20 + ThreadIdSize); |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 369 | |
| 370 | // Check the decl_id |
| 371 | offset += uint32_t_size; |
| 372 | uint32_t eventDeclId = ReadUint32(packetBuffer, offset); |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 373 | CHECK(eventDeclId == 4); |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 374 | |
| 375 | // Check the timestamp |
| 376 | offset += uint32_t_size; |
| 377 | uint64_t eventTimestamp = ReadUint64(packetBuffer, offset); |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 378 | CHECK(eventTimestamp == timestamp); |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 379 | |
| 380 | // Check the thread id |
| 381 | offset += uint64_t_size; |
Colm Donelan | 5bb3d8a | 2020-05-12 16:36:46 +0100 | [diff] [blame] | 382 | std::vector<uint8_t> readThreadId(ThreadIdSize, 0); |
| 383 | ReadBytes(packetBuffer, offset, ThreadIdSize, readThreadId.data()); |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 384 | CHECK(readThreadId == threadId); |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 385 | |
| 386 | // Check the profiling GUID |
Colm Donelan | 5bb3d8a | 2020-05-12 16:36:46 +0100 | [diff] [blame] | 387 | offset += ThreadIdSize; |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 388 | readProfilingGuid = ReadUint64(packetBuffer, offset); |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 389 | CHECK(readProfilingGuid == eventProfilingGuid); |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 390 | } |
| 391 | |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 392 | TEST_CASE("SendTimelinePacketTests2") |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 393 | { |
| 394 | MockBufferManager bufferManager(40); |
| 395 | TimelinePacketWriterFactory timelinePacketWriterFactory(bufferManager); |
| 396 | std::unique_ptr<ISendTimelinePacket> sendTimelinePacket = timelinePacketWriterFactory.GetSendTimelinePacket(); |
| 397 | |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 398 | CHECK_THROWS_AS(sendTimelinePacket->SendTimelineMessageDirectoryPackage(), |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 399 | armnn::RuntimeException); |
| 400 | } |
| 401 | |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 402 | TEST_CASE("SendTimelinePacketTests3") |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 403 | { |
| 404 | MockBufferManager bufferManager(512); |
| 405 | TimelinePacketWriterFactory timelinePacketWriterFactory(bufferManager); |
| 406 | std::unique_ptr<ISendTimelinePacket> sendTimelinePacket = timelinePacketWriterFactory.GetSendTimelinePacket(); |
| 407 | |
| 408 | // Send TimelineEntityClassBinaryPacket |
| 409 | const uint64_t entityBinaryPacketProfilingGuid = 123456u; |
| 410 | sendTimelinePacket->SendTimelineEntityBinaryPacket(entityBinaryPacketProfilingGuid); |
| 411 | |
| 412 | // Commit the buffer |
| 413 | sendTimelinePacket->Commit(); |
| 414 | |
| 415 | // Get the readable buffer |
| 416 | auto packetBuffer = bufferManager.GetReadableBuffer(); |
| 417 | |
| 418 | // Send TimelineEventClassBinaryPacket |
| 419 | const uint64_t eventClassBinaryPacketProfilingGuid = 789123u; |
Jim Flynn | 1892d21 | 2020-05-26 21:10:49 +0100 | [diff] [blame] | 420 | const uint64_t eventClassBinaryPacketNameGuid = 8845u; |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 421 | CHECK_THROWS_AS(sendTimelinePacket->SendTimelineEventClassBinaryPacket( |
Jim Flynn | 1892d21 | 2020-05-26 21:10:49 +0100 | [diff] [blame] | 422 | eventClassBinaryPacketProfilingGuid, eventClassBinaryPacketNameGuid), |
Jim Flynn | 6398a98 | 2020-05-27 17:05:21 +0100 | [diff] [blame] | 423 | armnn::profiling::BufferExhaustion); |
Sadik Armagan | 7bbdf9d | 2019-10-24 10:26:05 +0100 | [diff] [blame] | 424 | } |
| 425 | |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 426 | TEST_CASE("GetGuidsFromProfilingService") |
Jim Flynn | 00f3aaf | 2019-10-24 11:58:06 +0100 | [diff] [blame] | 427 | { |
Keith Davis | 33ed221 | 2020-03-30 10:43:41 +0100 | [diff] [blame] | 428 | armnn::IRuntime::CreationOptions options; |
| 429 | options.m_ProfilingOptions.m_EnableProfiling = true; |
Kevin May | d92a6e4 | 2021-02-04 10:27:41 +0000 | [diff] [blame] | 430 | armnn::RuntimeImpl runtime(options); |
Keith Davis | 33ed221 | 2020-03-30 10:43:41 +0100 | [diff] [blame] | 431 | armnn::profiling::ProfilingService profilingService(runtime); |
| 432 | |
| 433 | profilingService.ResetExternalProfilingOptions(options.m_ProfilingOptions, true); |
Sadik Armagan | 3184c90 | 2020-03-18 10:57:30 +0000 | [diff] [blame] | 434 | ProfilingStaticGuid staticGuid = profilingService.GetStaticId("dummy"); |
Jim Flynn | ab84575 | 2019-10-25 13:17:30 +0100 | [diff] [blame] | 435 | std::hash<std::string> hasher; |
| 436 | uint64_t hash = static_cast<uint64_t>(hasher("dummy")); |
Narumol Prangnawarat | dbdd1b4 | 2019-11-15 17:38:44 +0000 | [diff] [blame] | 437 | ProfilingStaticGuid expectedStaticValue(hash | MIN_STATIC_GUID); |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 438 | CHECK(staticGuid == expectedStaticValue); |
Sadik Armagan | 3184c90 | 2020-03-18 10:57:30 +0000 | [diff] [blame] | 439 | ProfilingDynamicGuid dynamicGuid = profilingService.GetNextGuid(); |
Jim Flynn | ab84575 | 2019-10-25 13:17:30 +0100 | [diff] [blame] | 440 | uint64_t dynamicGuidValue = static_cast<uint64_t>(dynamicGuid); |
| 441 | ++dynamicGuidValue; |
| 442 | ProfilingDynamicGuid expectedDynamicValue(dynamicGuidValue); |
Sadik Armagan | 3184c90 | 2020-03-18 10:57:30 +0000 | [diff] [blame] | 443 | dynamicGuid = profilingService.GetNextGuid(); |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 444 | CHECK(dynamicGuid == expectedDynamicValue); |
Jim Flynn | 00f3aaf | 2019-10-24 11:58:06 +0100 | [diff] [blame] | 445 | } |
| 446 | |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 447 | TEST_CASE("GetTimelinePackerWriterFromProfilingService") |
Jim Flynn | 8b20065 | 2019-10-24 18:07:44 +0100 | [diff] [blame] | 448 | { |
Narumol Prangnawarat | 85ad78c | 2019-11-18 15:34:23 +0000 | [diff] [blame] | 449 | armnn::IRuntime::CreationOptions::ExternalProfilingOptions options; |
Jim Flynn | 8b20065 | 2019-10-24 18:07:44 +0100 | [diff] [blame] | 450 | options.m_EnableProfiling = true; |
Sadik Armagan | 3184c90 | 2020-03-18 10:57:30 +0000 | [diff] [blame] | 451 | armnn::profiling::ProfilingService profilingService; |
Jim Flynn | 8b20065 | 2019-10-24 18:07:44 +0100 | [diff] [blame] | 452 | profilingService.ResetExternalProfilingOptions(options, true); |
| 453 | |
| 454 | std::unique_ptr<ISendTimelinePacket> writer = profilingService.GetSendTimelinePacket(); |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 455 | CHECK(writer != nullptr); |
Jim Flynn | 8b20065 | 2019-10-24 18:07:44 +0100 | [diff] [blame] | 456 | } |
| 457 | |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 458 | TEST_CASE("CheckStaticGuidsAndEvents") |
Jim Flynn | ab84575 | 2019-10-25 13:17:30 +0100 | [diff] [blame] | 459 | { |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 460 | CHECK("name" == LabelsAndEventClasses::NAME_LABEL); |
| 461 | CHECK("type" == LabelsAndEventClasses::TYPE_LABEL); |
| 462 | CHECK("index" == LabelsAndEventClasses::INDEX_LABEL); |
Jim Flynn | ab84575 | 2019-10-25 13:17:30 +0100 | [diff] [blame] | 463 | |
| 464 | std::hash<std::string> hasher; |
| 465 | |
| 466 | uint64_t hash = static_cast<uint64_t>(hasher(LabelsAndEventClasses::NAME_LABEL)); |
Narumol Prangnawarat | dbdd1b4 | 2019-11-15 17:38:44 +0000 | [diff] [blame] | 467 | ProfilingStaticGuid expectedNameGuid(hash | MIN_STATIC_GUID); |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 468 | CHECK(LabelsAndEventClasses::NAME_GUID == expectedNameGuid); |
Jim Flynn | ab84575 | 2019-10-25 13:17:30 +0100 | [diff] [blame] | 469 | |
| 470 | hash = static_cast<uint64_t>(hasher(LabelsAndEventClasses::TYPE_LABEL)); |
Narumol Prangnawarat | dbdd1b4 | 2019-11-15 17:38:44 +0000 | [diff] [blame] | 471 | ProfilingStaticGuid expectedTypeGuid(hash | MIN_STATIC_GUID); |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 472 | CHECK(LabelsAndEventClasses::TYPE_GUID == expectedTypeGuid); |
Jim Flynn | ab84575 | 2019-10-25 13:17:30 +0100 | [diff] [blame] | 473 | |
| 474 | hash = static_cast<uint64_t>(hasher(LabelsAndEventClasses::INDEX_LABEL)); |
Narumol Prangnawarat | dbdd1b4 | 2019-11-15 17:38:44 +0000 | [diff] [blame] | 475 | ProfilingStaticGuid expectedIndexGuid(hash | MIN_STATIC_GUID); |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 476 | CHECK(LabelsAndEventClasses::INDEX_GUID == expectedIndexGuid); |
Jim Flynn | ab84575 | 2019-10-25 13:17:30 +0100 | [diff] [blame] | 477 | |
| 478 | hash = static_cast<uint64_t>(hasher("ARMNN_PROFILING_SOL")); |
Narumol Prangnawarat | dbdd1b4 | 2019-11-15 17:38:44 +0000 | [diff] [blame] | 479 | ProfilingStaticGuid expectedSol(hash | MIN_STATIC_GUID); |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 480 | CHECK(LabelsAndEventClasses::ARMNN_PROFILING_SOL_EVENT_CLASS == expectedSol); |
Jim Flynn | ab84575 | 2019-10-25 13:17:30 +0100 | [diff] [blame] | 481 | |
| 482 | hash = static_cast<uint64_t>(hasher("ARMNN_PROFILING_EOL")); |
Narumol Prangnawarat | dbdd1b4 | 2019-11-15 17:38:44 +0000 | [diff] [blame] | 483 | ProfilingStaticGuid expectedEol(hash | MIN_STATIC_GUID); |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 484 | CHECK(LabelsAndEventClasses::ARMNN_PROFILING_EOL_EVENT_CLASS == expectedEol); |
Jim Flynn | ab84575 | 2019-10-25 13:17:30 +0100 | [diff] [blame] | 485 | } |
| 486 | |
Sadik Armagan | 1625efc | 2021-06-10 18:24:34 +0100 | [diff] [blame] | 487 | } |