MLECO-3842, MLECO-3801, MLECO-3899: Minor improvements
Some minor improvements in this patch:
* Added notes on troubleshooting WSL2 build issues.
* Fixed a stray guard for MPS3_PLATFORM from noise reduction
use-case.
* The default build script `build_default.py` will now return
an error code to the calling process if it fails.
Change-Id: I4557a402646fdf903b2cb043bf68d5d0b0d12972
Signed-off-by: Kshitij Sisodia <kshitij.sisodia@arm.com>
diff --git a/build_default.py b/build_default.py
index e35aa1c..1badb02 100755
--- a/build_default.py
+++ b/build_default.py
@@ -1,5 +1,5 @@
#!/usr/bin/env python3
-# SPDX-FileCopyrightText: Copyright 2021-2022 Arm Limited and/or its affiliates <open-source-office@arm.com>
+# SPDX-FileCopyrightText: Copyright 2021-2023 Arm Limited and/or its affiliates <open-source-office@arm.com>
# SPDX-License-Identifier: Apache-2.0
#
# Licensed under the Apache License, Version 2.0 (the "License");
@@ -130,6 +130,11 @@
cmake_command, shell=True, stdout=logpipe, stderr=subprocess.STDOUT
)
+ if state.returncode != 0:
+ logging.error("Failed to configure the project.")
+ logpipe.close()
+ sys.exit(state.returncode)
+
make_command = f"{cmake_path} --build {build_dir} -j{make_jobs}"
if make_verbose:
make_command += "--verbose"
@@ -138,6 +143,11 @@
make_command, shell=True, stdout=logpipe, stderr=subprocess.STDOUT
)
+ if state.returncode != 0:
+ logging.error("Failed to build project.")
+ logpipe.close()
+ sys.exit(state.returncode)
+
logpipe.close()