commit 43ba0dd3ea46d85267914c3b25cb8f9fdd719789
author Gunes Bayir <gunes.bayir@arm.com> Tue Mar 19 15:31:11 2024 +0000
committer Gunes Bayir <gunes.bayir@arm.com> Tue Mar 19 17:46:04 2024 +0000
tree 68c514ecc14f9325a290bd39d82c2545a2276708
parent c00a82b1467c02e46093b65f29aaad8fbf794dfe

Increase MatMul and DilatedConv test Q8 thresholds to 1

Tolerance for quantized tests is better to be 1 due to possible rounding differences between the Acl and reference implementations.

Resolves: COMPMID-6929
Change-Id: I6f317631322b702e6a9579593befff65bbf46151
Signed-off-by: Gunes Bayir <gunes.bayir@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/11319
Reviewed-by: Pablo Marquez Tello <pablo.tello@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Benchmark: Arm Jenkins <bsgcomp@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>

tests/validation/NEON/DilatedConvolutionLayer.cpp

diff --git a/tests/validation/NEON/DilatedConvolutionLayer.cpp b/tests/validation/NEON/DilatedConvolutionLayer.cpp
index 2ede4fa..fbfe8b8 100644
--- a/tests/validation/NEON/DilatedConvolutionLayer.cpp
+++ b/tests/validation/NEON/DilatedConvolutionLayer.cpp
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2018-2021, 2023 Arm Limited.
+ * Copyright (c) 2018-2021, 2023-2024 Arm Limited.
  *
  * SPDX-License-Identifier: MIT
  *
@@ -50,7 +50,7 @@
 const RelativeTolerance<half_float::half> rel_tolerance_f16(half_float::half(0.2f)); /**< Relative tolerance value for comparing reference's output against implementation's output for DataType::F16 */
 constexpr float                           tolerance_num_f16 = 0.07f;                 /**< Tolerance number for FP16 */
 #endif                                                                               /* __ARM_FEATURE_FP16_VECTOR_ARITHMETIC */
-constexpr AbsoluteTolerance<float> tolerance_qasymm8(0.0);                           /**< Tolerance value for comparing reference's output against implementation's output for quantized data types */
+constexpr AbsoluteTolerance<int32_t> tolerance_qasymm8(1);                           /**< Tolerance value for comparing reference's output against implementation's output for quantized data types */
 
 /** CNN data types */
 const auto CNNDataTypes = framework::dataset::make("DataType",

tests/validation/NEON/MatMul.cpp

diff --git a/tests/validation/NEON/MatMul.cpp b/tests/validation/NEON/MatMul.cpp
index 5577a9b..f91dea1 100644
--- a/tests/validation/NEON/MatMul.cpp
+++ b/tests/validation/NEON/MatMul.cpp
@@ -48,8 +48,8 @@
 constexpr AbsoluteTolerance<float>   tolerance_fp32(0.001f); /**< Tolerance value for comparing reference's output against implementation's output for FP32 data types */
 const AbsoluteTolerance<half>        tolerance_fp16(half(0.1f));
 #ifdef __aarch64__
-constexpr AbsoluteTolerance<uint8_t> tolerance_qasymm8(0);
-constexpr AbsoluteTolerance<uint8_t> tolerance_qasymm8_signed(0);
+constexpr AbsoluteTolerance<int32_t> tolerance_qasymm8(1);
+constexpr AbsoluteTolerance<int32_t> tolerance_qasymm8_signed(1);
 #endif // __aarch64__
 
 // clang-format off