MLBEDSW-2272 Reenable the version checker for optimizer config
Also check that the command stream address and base address are
aligned to 16 bytes. Return error in case they are not correctly
aligned.
Change-Id: I786d03f403d02d601ee74c53d2dede85b2b0e8a0
diff --git a/src/ethosu_device.c b/src/ethosu_device.c
index 7ce8fad..d6360f4 100644
--- a/src/ethosu_device.c
+++ b/src/ethosu_device.c
@@ -15,15 +15,17 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-
#include "ethosu_device.h"
-
#include "ethosu_common.h"
+
#include <assert.h>
+#include <stdbool.h>
+#include <stddef.h>
#include <stdio.h>
#define MASK_0_31_BITS 0xFFFFFFFF
#define MASK_32_47_BITS 0xFFFF00000000
+#define MASK_16_BYTE_ALIGN 0xF
#define BASEP_OFFSET 4
#define REG_OFFSET 4
#define BYTES_1KB 1024
@@ -90,6 +92,26 @@
ASSERT(num_base_addr <= ETHOSU_DRIVER_BASEP_INDEXES);
+ if (0 != ((ptrdiff_t)cmd_stream_ptr & MASK_16_BYTE_ALIGN))
+ {
+ LOG_ERR("Error: Command stream addr %p not aligned to 16 bytes\n", cmd_stream_ptr);
+ return ETHOSU_INVALID_PARAM;
+ }
+
+ bool base_addr_invalid = false;
+ for (int i = 0; i < num_base_addr; i++)
+ {
+ if (0 != (base_addr[i] & MASK_16_BYTE_ALIGN))
+ {
+ LOG_ERR("Error: Base addr %d: %p not aligned to 16 bytes\n", i, (void *)(base_addr[i]));
+ base_addr_invalid = true;
+ }
+ }
+ if (base_addr_invalid)
+ {
+ return ETHOSU_INVALID_PARAM;
+ }
+
qbase0 = ((uint64_t)cmd_stream_ptr) & MASK_0_31_BITS;
qbase1 = (((uint64_t)cmd_stream_ptr) & MASK_32_47_BITS) >> 32;
qsize = cms_length;
diff --git a/src/ethosu_driver.c b/src/ethosu_driver.c
index 8384ebe..148514a 100644
--- a/src/ethosu_driver.c
+++ b/src/ethosu_driver.c
@@ -16,8 +16,8 @@
* limitations under the License.
*/
-#include "ethosu_config.h"
#include "ethosu_driver.h"
+#include "ethosu_config.h"
#include "ethosu_common.h"
#include "ethosu_device.h"
@@ -95,6 +95,7 @@
#define APB_NUM_REG_BIT_SHIFT 12
#define CMS_ALIGNMENT 16
#define BYTES_1KB 1024
+#define PRODUCT_MAJOR_ETHOSU55 (4)
// Driver actions
enum DRIVER_ACTION_e
@@ -378,18 +379,18 @@
return_code = -1;
}
- if ((id.arch_major_rev != opt_cfg_p->arch_major_rev) || (id.arch_minor_rev != opt_cfg_p->arch_minor_rev) ||
- (id.arch_patch_rev != opt_cfg_p->arch_patch_rev))
+ if ((id.product_major == PRODUCT_MAJOR_ETHOSU55) &&
+ ((id.arch_major_rev != opt_cfg_p->arch_major_rev) || (id.arch_minor_rev != opt_cfg_p->arch_minor_rev) ||
+ (id.arch_patch_rev != opt_cfg_p->arch_patch_rev)))
{
- // fLOG_INFO(stderr,
- // "NPU arch mismatch: npu.arch=%d.%d.%d optimizer.arch=%d.%d.%d\n",
- // id.arch_major_rev,
- // id.arch_minor_rev,
- // id.arch_patch_rev,
- // opt_cfg_p->arch_major_rev,
- // opt_cfg_p->arch_minor_rev,
- // opt_cfg_p->arch_patch_rev);
- // return_code = -1;
+ LOG_ERR("NPU arch mismatch: npu.arch=%d.%d.%d optimizer.arch=%d.%d.%d\n",
+ id.arch_major_rev,
+ id.arch_minor_rev,
+ id.arch_patch_rev,
+ opt_cfg_p->arch_major_rev,
+ opt_cfg_p->arch_minor_rev,
+ opt_cfg_p->arch_patch_rev);
+ return_code = -1;
}
#if !defined(LOG_ENABLED)
@@ -411,26 +412,22 @@
ethosu_set_regioncfg(6, NPU_REGIONCFG_6);
ethosu_set_regioncfg(7, NPU_REGIONCFG_7);
- (void)ethosu_set_axi_limit0(
- AXI_LIMIT0_MAX_BEATS_BYTES,
- AXI_LIMIT0_MEM_TYPE,
- AXI_LIMIT0_MAX_OUTSTANDING_READS,
- AXI_LIMIT0_MAX_OUTSTANDING_WRITES);
- (void)ethosu_set_axi_limit1(
- AXI_LIMIT1_MAX_BEATS_BYTES,
- AXI_LIMIT1_MEM_TYPE,
- AXI_LIMIT1_MAX_OUTSTANDING_READS,
- AXI_LIMIT1_MAX_OUTSTANDING_WRITES);
- (void)ethosu_set_axi_limit2(
- AXI_LIMIT2_MAX_BEATS_BYTES,
- AXI_LIMIT2_MEM_TYPE,
- AXI_LIMIT2_MAX_OUTSTANDING_READS,
- AXI_LIMIT2_MAX_OUTSTANDING_WRITES);
- (void)ethosu_set_axi_limit3(
- AXI_LIMIT3_MAX_BEATS_BYTES,
- AXI_LIMIT3_MEM_TYPE,
- AXI_LIMIT3_MAX_OUTSTANDING_READS,
- AXI_LIMIT3_MAX_OUTSTANDING_WRITES);
+ (void)ethosu_set_axi_limit0(AXI_LIMIT0_MAX_BEATS_BYTES,
+ AXI_LIMIT0_MEM_TYPE,
+ AXI_LIMIT0_MAX_OUTSTANDING_READS,
+ AXI_LIMIT0_MAX_OUTSTANDING_WRITES);
+ (void)ethosu_set_axi_limit1(AXI_LIMIT1_MAX_BEATS_BYTES,
+ AXI_LIMIT1_MEM_TYPE,
+ AXI_LIMIT1_MAX_OUTSTANDING_READS,
+ AXI_LIMIT1_MAX_OUTSTANDING_WRITES);
+ (void)ethosu_set_axi_limit2(AXI_LIMIT2_MAX_BEATS_BYTES,
+ AXI_LIMIT2_MEM_TYPE,
+ AXI_LIMIT2_MAX_OUTSTANDING_READS,
+ AXI_LIMIT2_MAX_OUTSTANDING_WRITES);
+ (void)ethosu_set_axi_limit3(AXI_LIMIT3_MAX_BEATS_BYTES,
+ AXI_LIMIT3_MEM_TYPE,
+ AXI_LIMIT3_MAX_OUTSTANDING_READS,
+ AXI_LIMIT3_MAX_OUTSTANDING_WRITES);
}
static int handle_command_stream(const uint8_t *cmd_stream,
@@ -449,7 +446,10 @@
}
npu_axi_init();
- ethosu_run_command_stream(cmd_stream, cms_bytes, base_addr, num_base_addr);
+ if (ETHOSU_SUCCESS != ethosu_run_command_stream(cmd_stream, cms_bytes, base_addr, num_base_addr))
+ {
+ return -1;
+ }
wait_for_irq();