commit bf7ae6313fbbc024ecf3c1177f007a8152c36b73
author Bhavik Patel <bhavik.patel@arm.com> Thu Jun 11 21:00:16 2020 +0200
committer Bhavik Patel <bhavik.patel@arm.com> Fri Jun 12 09:52:25 2020 +0200
tree d924df16e0c12b7e2a49a9d6350463088c2f5620
parent 790ef36ae09f421f17c7a7aa3ae055894a8397fc

Move command stream and base address alignment checks

Moving the alignment checks for command stream and base addresses
to handle_command_stream(). This is done so that applications which
directly call ethosu_run_command_stream(), and don't have command
stream & base addresses properly aligned can still run the command
stream.

Change-Id: Ie02e9952af027e3017e53ea7217698a33a33b418

src/ethosu_device.c

diff --git a/src/ethosu_device.c b/src/ethosu_device.c
index d6360f4..7df8b6f 100644
--- a/src/ethosu_device.c
+++ b/src/ethosu_device.c
@@ -19,13 +19,10 @@
 #include "ethosu_common.h"
 
 #include <assert.h>
-#include <stdbool.h>
-#include <stddef.h>
 #include <stdio.h>
 
 #define MASK_0_31_BITS 0xFFFFFFFF
 #define MASK_32_47_BITS 0xFFFF00000000
-#define MASK_16_BYTE_ALIGN 0xF
 #define BASEP_OFFSET 4
 #define REG_OFFSET 4
 #define BYTES_1KB 1024
@@ -92,26 +89,6 @@
 
     ASSERT(num_base_addr <= ETHOSU_DRIVER_BASEP_INDEXES);
 
-    if (0 != ((ptrdiff_t)cmd_stream_ptr & MASK_16_BYTE_ALIGN))
-    {
-        LOG_ERR("Error: Command stream addr %p not aligned to 16 bytes\n", cmd_stream_ptr);
-        return ETHOSU_INVALID_PARAM;
-    }
-
-    bool base_addr_invalid = false;
-    for (int i = 0; i < num_base_addr; i++)
-    {
-        if (0 != (base_addr[i] & MASK_16_BYTE_ALIGN))
-        {
-            LOG_ERR("Error: Base addr %d: %p not aligned to 16 bytes\n", i, (void *)(base_addr[i]));
-            base_addr_invalid = true;
-        }
-    }
-    if (base_addr_invalid)
-    {
-        return ETHOSU_INVALID_PARAM;
-    }
-
     qbase0       = ((uint64_t)cmd_stream_ptr) & MASK_0_31_BITS;
     qbase1       = (((uint64_t)cmd_stream_ptr) & MASK_32_47_BITS) >> 32;
     qsize        = cms_length;

src/ethosu_driver.c

diff --git a/src/ethosu_driver.c b/src/ethosu_driver.c
index 148514a..abc8274 100644
--- a/src/ethosu_driver.c
+++ b/src/ethosu_driver.c
@@ -25,6 +25,7 @@
 #include <assert.h>
 #include <cmsis_compiler.h>
 #include <stdbool.h>
+#include <stddef.h>
 #include <stdint.h>
 #include <stdio.h>
 #include <stdlib.h>
@@ -93,9 +94,9 @@
 #define ETHOSU_FOURCC ('1' << 24 | 'P' << 16 | 'O' << 8 | 'C') // "Custom Operator Payload 1"
 #define APB_START_ADDR_MASK 0x0FFF
 #define APB_NUM_REG_BIT_SHIFT 12
-#define CMS_ALIGNMENT 16
 #define BYTES_1KB 1024
 #define PRODUCT_MAJOR_ETHOSU55 (4)
+#define MASK_16_BYTE_ALIGN (0xF)
 
 // Driver actions
 enum DRIVER_ACTION_e
@@ -439,9 +440,23 @@
     uint32_t cms_bytes = cms_length * BYTES_IN_32_BITS;
     LOG_INFO("handle_command_stream cms_length %d\n", cms_length);
 
-    if (((uint32_t)cmd_stream % CMS_ALIGNMENT) != 0)
+    if (0 != ((ptrdiff_t)cmd_stream & MASK_16_BYTE_ALIGN))
     {
-        LOG_ERR("Failure: Command stream addr %p not aligned to 16 bytes\n", cmd_stream);
+        LOG_ERR("Error: Command stream addr %p not aligned to 16 bytes\n", cmd_stream);
+        return -1;
+    }
+
+    bool base_addr_invalid = false;
+    for (int i = 0; i < num_base_addr; i++)
+    {
+        if (0 != (base_addr[i] & MASK_16_BYTE_ALIGN))
+        {
+            LOG_ERR("Error: Base addr %d: %p not aligned to 16 bytes\n", i, (void *)(base_addr[i]));
+            base_addr_invalid = true;
+        }
+    }
+    if (base_addr_invalid)
+    {
         return -1;
     }
     npu_axi_init();