Jonny Svärd | 136810f | 2021-10-13 16:04:26 +0200 | [diff] [blame] | 1 | /* |
Jonny Svärd | d1750ec | 2022-01-04 10:59:16 +0100 | [diff] [blame] | 2 | * Copyright (c) 2019-2022 Arm Limited. All rights reserved. |
Jonny Svärd | 136810f | 2021-10-13 16:04:26 +0200 | [diff] [blame] | 3 | * |
| 4 | * SPDX-License-Identifier: Apache-2.0 |
| 5 | * |
| 6 | * Licensed under the Apache License, Version 2.0 (the License); you may |
| 7 | * not use this file except in compliance with the License. |
| 8 | * You may obtain a copy of the License at |
| 9 | * |
| 10 | * www.apache.org/licenses/LICENSE-2.0 |
| 11 | * |
| 12 | * Unless required by applicable law or agreed to in writing, software |
| 13 | * distributed under the License is distributed on an AS IS BASIS, WITHOUT |
| 14 | * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 15 | * See the License for the specific language governing permissions and |
| 16 | * limitations under the License. |
| 17 | */ |
Jonny Svärd | d1750ec | 2022-01-04 10:59:16 +0100 | [diff] [blame] | 18 | |
Jonny Svärd | 136810f | 2021-10-13 16:04:26 +0200 | [diff] [blame] | 19 | #include "ethosu_interface.h" |
| 20 | |
| 21 | #include "ethosu_config.h" |
| 22 | #include "ethosu_device.h" |
| 23 | #include "ethosu_log.h" |
| 24 | |
| 25 | #include <assert.h> |
| 26 | #include <inttypes.h> |
| 27 | #include <stdbool.h> |
| 28 | #include <stddef.h> |
| 29 | #include <stdio.h> |
| 30 | #include <stdlib.h> |
| 31 | |
Jonny Svärd | d1750ec | 2022-01-04 10:59:16 +0100 | [diff] [blame] | 32 | #define ETHOSU_PRODUCT_U55 0 |
| 33 | #define ETHOSU_PRODUCT_U65 1 |
| 34 | |
Jonny Svärd | 136810f | 2021-10-13 16:04:26 +0200 | [diff] [blame] | 35 | #define BASEP_OFFSET 4 |
| 36 | |
| 37 | #ifdef ETHOSU65 |
| 38 | #define ADDRESS_BITS 40 |
| 39 | #else |
| 40 | #define ADDRESS_BITS 32 |
| 41 | #endif |
| 42 | |
| 43 | #define ADDRESS_MASK ((1ull << ADDRESS_BITS) - 1) |
| 44 | |
| 45 | #define NPU_CMD_PWR_CLK_MASK (0xC) |
| 46 | |
| 47 | struct ethosu_device *ethosu_dev_init(const void *base_address, uint32_t secure_enable, uint32_t privilege_enable) |
| 48 | { |
| 49 | struct ethosu_device *dev = malloc(sizeof(struct ethosu_device)); |
| 50 | if (!dev) |
| 51 | { |
Kristofer Jonsson | 089a347 | 2021-11-12 12:52:07 +0100 | [diff] [blame] | 52 | LOG_ERR("Failed to allocate memory for Ethos-U device"); |
Jonny Svärd | 136810f | 2021-10-13 16:04:26 +0200 | [diff] [blame] | 53 | return NULL; |
| 54 | } |
| 55 | |
| 56 | dev->reg = (volatile struct NPU_REG *)base_address; |
| 57 | dev->secure = secure_enable; |
| 58 | dev->privileged = privilege_enable; |
| 59 | |
Jonny Svärd | d1750ec | 2022-01-04 10:59:16 +0100 | [diff] [blame] | 60 | #ifdef ETHOSU55 |
| 61 | if (dev->reg->CONFIG.product != ETHOSU_PRODUCT_U55) |
| 62 | #else |
| 63 | if (dev->reg->CONFIG.product != ETHOSU_PRODUCT_U65) |
| 64 | #endif |
| 65 | { |
| 66 | LOG_ERR("Failed to initialize device. Driver has not been compiled for this product"); |
| 67 | goto err; |
| 68 | } |
| 69 | |
Jonny Svärd | 136810f | 2021-10-13 16:04:26 +0200 | [diff] [blame] | 70 | // Make sure the NPU is in a known state |
| 71 | if (ethosu_dev_soft_reset(dev) != ETHOSU_SUCCESS) |
| 72 | { |
Jonny Svärd | d1750ec | 2022-01-04 10:59:16 +0100 | [diff] [blame] | 73 | goto err; |
Jonny Svärd | 136810f | 2021-10-13 16:04:26 +0200 | [diff] [blame] | 74 | } |
| 75 | |
| 76 | return dev; |
Jonny Svärd | d1750ec | 2022-01-04 10:59:16 +0100 | [diff] [blame] | 77 | |
| 78 | err: |
| 79 | free(dev); |
| 80 | return NULL; |
Jonny Svärd | 136810f | 2021-10-13 16:04:26 +0200 | [diff] [blame] | 81 | } |
| 82 | |
| 83 | void ethosu_dev_deinit(struct ethosu_device *dev) |
| 84 | { |
| 85 | free(dev); |
| 86 | } |
| 87 | |
| 88 | enum ethosu_error_codes ethosu_dev_axi_init(struct ethosu_device *dev) |
| 89 | { |
| 90 | struct regioncfg_r rcfg = {0}; |
| 91 | struct axi_limit0_r l0 = {0}; |
| 92 | struct axi_limit1_r l1 = {0}; |
| 93 | struct axi_limit2_r l2 = {0}; |
| 94 | struct axi_limit3_r l3 = {0}; |
| 95 | |
| 96 | dev->reg->QCONFIG.word = NPU_QCONFIG; |
| 97 | |
| 98 | rcfg.region0 = NPU_REGIONCFG_0; |
| 99 | rcfg.region1 = NPU_REGIONCFG_1; |
| 100 | rcfg.region2 = NPU_REGIONCFG_2; |
| 101 | rcfg.region3 = NPU_REGIONCFG_3; |
| 102 | rcfg.region4 = NPU_REGIONCFG_4; |
| 103 | rcfg.region5 = NPU_REGIONCFG_5; |
| 104 | rcfg.region6 = NPU_REGIONCFG_6; |
| 105 | rcfg.region7 = NPU_REGIONCFG_7; |
| 106 | dev->reg->REGIONCFG.word = rcfg.word; |
| 107 | |
| 108 | l0.max_beats = AXI_LIMIT0_MAX_BEATS_BYTES; |
| 109 | l0.memtype = AXI_LIMIT0_MEM_TYPE; |
| 110 | l0.max_outstanding_read_m1 = AXI_LIMIT0_MAX_OUTSTANDING_READS - 1; |
| 111 | l0.max_outstanding_write_m1 = AXI_LIMIT0_MAX_OUTSTANDING_WRITES - 1; |
| 112 | |
| 113 | l1.max_beats = AXI_LIMIT1_MAX_BEATS_BYTES; |
| 114 | l1.memtype = AXI_LIMIT1_MEM_TYPE; |
| 115 | l1.max_outstanding_read_m1 = AXI_LIMIT1_MAX_OUTSTANDING_READS - 1; |
| 116 | l1.max_outstanding_write_m1 = AXI_LIMIT1_MAX_OUTSTANDING_WRITES - 1; |
| 117 | |
| 118 | l2.max_beats = AXI_LIMIT2_MAX_BEATS_BYTES; |
| 119 | l2.memtype = AXI_LIMIT2_MEM_TYPE; |
| 120 | l2.max_outstanding_read_m1 = AXI_LIMIT2_MAX_OUTSTANDING_READS - 1; |
| 121 | l2.max_outstanding_write_m1 = AXI_LIMIT2_MAX_OUTSTANDING_WRITES - 1; |
| 122 | |
| 123 | l3.max_beats = AXI_LIMIT3_MAX_BEATS_BYTES; |
| 124 | l3.memtype = AXI_LIMIT3_MEM_TYPE; |
| 125 | l3.max_outstanding_read_m1 = AXI_LIMIT3_MAX_OUTSTANDING_READS - 1; |
| 126 | l3.max_outstanding_write_m1 = AXI_LIMIT3_MAX_OUTSTANDING_WRITES - 1; |
| 127 | |
| 128 | dev->reg->AXI_LIMIT0.word = l0.word; |
| 129 | dev->reg->AXI_LIMIT1.word = l1.word; |
| 130 | dev->reg->AXI_LIMIT2.word = l2.word; |
| 131 | dev->reg->AXI_LIMIT3.word = l3.word; |
| 132 | |
| 133 | return ETHOSU_SUCCESS; |
| 134 | } |
| 135 | |
| 136 | enum ethosu_error_codes ethosu_dev_run_command_stream(struct ethosu_device *dev, |
| 137 | const uint8_t *cmd_stream_ptr, |
| 138 | uint32_t cms_length, |
| 139 | const uint64_t *base_addr, |
| 140 | int num_base_addr) |
| 141 | { |
| 142 | assert(num_base_addr <= NPU_REG_BASEP_ARRLEN); |
| 143 | |
| 144 | struct cmd_r cmd; |
| 145 | uint64_t qbase = (uintptr_t)cmd_stream_ptr + BASE_POINTER_OFFSET; |
| 146 | assert(qbase <= ADDRESS_MASK); |
Kristofer Jonsson | 089a347 | 2021-11-12 12:52:07 +0100 | [diff] [blame] | 147 | LOG_DEBUG("QBASE=0x%016llx, QSIZE=%u, base_pointer_offset=0x%08x", qbase, cms_length, BASE_POINTER_OFFSET); |
Jonny Svärd | 136810f | 2021-10-13 16:04:26 +0200 | [diff] [blame] | 148 | |
| 149 | dev->reg->QBASE.word[0] = qbase & 0xffffffff; |
| 150 | #ifdef ETHOSU65 |
| 151 | dev->reg->QBASE.word[1] = qbase >> 32; |
| 152 | #endif |
| 153 | dev->reg->QSIZE.word = cms_length; |
| 154 | |
| 155 | for (int i = 0; i < num_base_addr; i++) |
| 156 | { |
| 157 | uint64_t addr = base_addr[i] + BASE_POINTER_OFFSET; |
| 158 | assert(addr <= ADDRESS_MASK); |
Kristofer Jonsson | 089a347 | 2021-11-12 12:52:07 +0100 | [diff] [blame] | 159 | LOG_DEBUG("BASEP%d=0x%016llx", i, addr); |
Jonny Svärd | 136810f | 2021-10-13 16:04:26 +0200 | [diff] [blame] | 160 | dev->reg->BASEP[i].word[0] = addr & 0xffffffff; |
| 161 | #ifdef ETHOSU65 |
| 162 | dev->reg->BASEP[i].word[1] = addr >> 32; |
| 163 | #endif |
| 164 | } |
| 165 | |
| 166 | cmd.word = dev->reg->CMD.word & NPU_CMD_PWR_CLK_MASK; |
| 167 | cmd.transition_to_running_state = 1; |
| 168 | |
| 169 | dev->reg->CMD.word = cmd.word; |
Kristofer Jonsson | 089a347 | 2021-11-12 12:52:07 +0100 | [diff] [blame] | 170 | LOG_DEBUG("CMD=0x%08x", cmd.word); |
Jonny Svärd | 136810f | 2021-10-13 16:04:26 +0200 | [diff] [blame] | 171 | |
| 172 | return ETHOSU_SUCCESS; |
| 173 | } |
| 174 | |
| 175 | bool ethosu_dev_handle_interrupt(struct ethosu_device *dev) |
| 176 | { |
| 177 | struct cmd_r cmd; |
| 178 | |
| 179 | // Clear interrupt |
| 180 | cmd.word = dev->reg->CMD.word & NPU_CMD_PWR_CLK_MASK; |
| 181 | cmd.clear_irq = 1; |
| 182 | dev->reg->CMD.word = cmd.word; |
| 183 | |
| 184 | // If a fault has occured, the NPU needs to be reset |
| 185 | if (dev->reg->STATUS.bus_status || dev->reg->STATUS.cmd_parse_error || dev->reg->STATUS.wd_fault || |
Jonny Svärd | 6d5b083 | 2021-11-30 14:54:07 +0100 | [diff] [blame] | 186 | dev->reg->STATUS.ecc_fault || !dev->reg->STATUS.cmd_end_reached) |
Jonny Svärd | 136810f | 2021-10-13 16:04:26 +0200 | [diff] [blame] | 187 | { |
Kristofer Jonsson | b3cde3c | 2022-01-27 17:30:15 +0100 | [diff] [blame^] | 188 | LOG_ERR("NPU fault. status=0x%08" PRIx32 ", qread=%" PRIu32 ", cmd_end_reached=%d", |
Jonny Svärd | 6d5b083 | 2021-11-30 14:54:07 +0100 | [diff] [blame] | 189 | dev->reg->STATUS.word, |
| 190 | dev->reg->QREAD.word, |
| 191 | dev->reg->STATUS.cmd_end_reached); |
Jonny Svärd | 136810f | 2021-10-13 16:04:26 +0200 | [diff] [blame] | 192 | ethosu_dev_soft_reset(dev); |
| 193 | ethosu_dev_set_clock_and_power(dev, ETHOSU_CLOCK_Q_UNCHANGED, ETHOSU_POWER_Q_DISABLE); |
| 194 | return false; |
| 195 | } |
| 196 | |
Jonny Svärd | 6d5b083 | 2021-11-30 14:54:07 +0100 | [diff] [blame] | 197 | return true; |
Jonny Svärd | 136810f | 2021-10-13 16:04:26 +0200 | [diff] [blame] | 198 | } |
| 199 | |
| 200 | bool ethosu_dev_verify_access_state(struct ethosu_device *dev) |
| 201 | { |
| 202 | if (dev->reg->PROT.active_CSL != (dev->secure ? SECURITY_LEVEL_SECURE : SECURITY_LEVEL_NON_SECURE) || |
| 203 | dev->reg->PROT.active_CPL != (dev->privileged ? PRIVILEGE_LEVEL_PRIVILEGED : PRIVILEGE_LEVEL_USER)) |
| 204 | { |
| 205 | return false; |
| 206 | } |
| 207 | return true; |
| 208 | } |
| 209 | |
| 210 | enum ethosu_error_codes ethosu_dev_soft_reset(struct ethosu_device *dev) |
| 211 | { |
| 212 | struct reset_r reset; |
| 213 | |
| 214 | reset.word = 0; |
| 215 | reset.pending_CPL = dev->privileged ? PRIVILEGE_LEVEL_PRIVILEGED : PRIVILEGE_LEVEL_USER; |
| 216 | reset.pending_CSL = dev->secure ? SECURITY_LEVEL_SECURE : SECURITY_LEVEL_NON_SECURE; |
| 217 | |
| 218 | // Reset and set security level |
Kristofer Jonsson | 089a347 | 2021-11-12 12:52:07 +0100 | [diff] [blame] | 219 | LOG_INFO("Soft reset NPU"); |
Jonny Svärd | 136810f | 2021-10-13 16:04:26 +0200 | [diff] [blame] | 220 | dev->reg->RESET.word = reset.word; |
| 221 | |
| 222 | // Wait until reset status indicates that reset has been completed |
| 223 | for (int i = 0; i < 100000 && dev->reg->STATUS.reset_status != 0; i++) |
| 224 | { |
| 225 | } |
| 226 | |
| 227 | if (dev->reg->STATUS.reset_status != 0) |
| 228 | { |
Kristofer Jonsson | 089a347 | 2021-11-12 12:52:07 +0100 | [diff] [blame] | 229 | LOG_ERR("Soft reset timed out"); |
Jonny Svärd | 136810f | 2021-10-13 16:04:26 +0200 | [diff] [blame] | 230 | return ETHOSU_GENERIC_FAILURE; |
| 231 | } |
| 232 | |
| 233 | // Verify that NPU has switched security state and privilege level |
| 234 | if (ethosu_dev_verify_access_state(dev) != true) |
| 235 | { |
Kristofer Jonsson | 089a347 | 2021-11-12 12:52:07 +0100 | [diff] [blame] | 236 | LOG_ERR("Failed to switch security state and privilege level"); |
Jonny Svärd | 136810f | 2021-10-13 16:04:26 +0200 | [diff] [blame] | 237 | return ETHOSU_GENERIC_FAILURE; |
| 238 | } |
| 239 | |
| 240 | // Reinitialize AXI settings |
| 241 | ethosu_dev_axi_init(dev); |
| 242 | |
| 243 | return ETHOSU_SUCCESS; |
| 244 | } |
| 245 | |
| 246 | void ethosu_dev_get_hw_info(struct ethosu_device *dev, struct ethosu_hw_info *hwinfo) |
| 247 | { |
| 248 | struct config_r cfg; |
| 249 | struct id_r id; |
| 250 | |
| 251 | cfg.word = dev->reg->CONFIG.word; |
| 252 | id.word = dev->reg->ID.word; |
| 253 | |
| 254 | hwinfo->cfg.cmd_stream_version = cfg.cmd_stream_version; |
| 255 | hwinfo->cfg.custom_dma = cfg.custom_dma; |
| 256 | hwinfo->cfg.macs_per_cc = cfg.macs_per_cc; |
| 257 | |
| 258 | hwinfo->version.arch_major_rev = id.arch_major_rev; |
| 259 | hwinfo->version.arch_minor_rev = id.arch_minor_rev; |
| 260 | hwinfo->version.arch_patch_rev = id.arch_patch_rev; |
| 261 | hwinfo->version.product_major = id.product_major; |
| 262 | hwinfo->version.version_major = id.version_major; |
| 263 | hwinfo->version.version_minor = id.version_minor; |
| 264 | hwinfo->version.version_status = id.version_status; |
| 265 | } |
| 266 | |
| 267 | enum ethosu_error_codes ethosu_dev_set_clock_and_power(struct ethosu_device *dev, |
| 268 | enum ethosu_clock_q_request clock_q, |
| 269 | enum ethosu_power_q_request power_q) |
| 270 | { |
| 271 | struct cmd_r cmd = {0}; |
| 272 | cmd.word = dev->reg->CMD.word & NPU_CMD_PWR_CLK_MASK; |
| 273 | |
| 274 | if (power_q != ETHOSU_POWER_Q_UNCHANGED) |
| 275 | { |
| 276 | cmd.power_q_enable = power_q == ETHOSU_POWER_Q_ENABLE ? 1 : 0; |
| 277 | } |
| 278 | if (clock_q != ETHOSU_CLOCK_Q_UNCHANGED) |
| 279 | { |
| 280 | cmd.clock_q_enable = clock_q == ETHOSU_CLOCK_Q_ENABLE ? 1 : 0; |
| 281 | } |
| 282 | |
| 283 | dev->reg->CMD.word = cmd.word; |
Kristofer Jonsson | 089a347 | 2021-11-12 12:52:07 +0100 | [diff] [blame] | 284 | LOG_DEBUG("CMD=0x%08x", cmd.word); |
Jonny Svärd | 136810f | 2021-10-13 16:04:26 +0200 | [diff] [blame] | 285 | |
| 286 | return ETHOSU_SUCCESS; |
| 287 | } |
| 288 | |
| 289 | bool ethosu_dev_verify_optimizer_config(struct ethosu_device *dev, uint32_t cfg_in, uint32_t id_in) |
| 290 | { |
| 291 | struct config_r *opt_cfg = (struct config_r *)&cfg_in; |
| 292 | struct config_r hw_cfg; |
| 293 | struct id_r *opt_id = (struct id_r *)&id_in; |
| 294 | struct id_r hw_id; |
| 295 | bool ret = true; |
| 296 | |
| 297 | hw_cfg.word = dev->reg->CONFIG.word; |
| 298 | hw_id.word = dev->reg->ID.word; |
| 299 | |
Jonny Svärd | d1750ec | 2022-01-04 10:59:16 +0100 | [diff] [blame] | 300 | LOG_INFO("Optimizer config. product=%d, cmd_stream_version=%d, macs_per_cc=%d, shram_size=%d, custom_dma=%d", |
| 301 | opt_cfg->product, |
Jonny Svärd | 136810f | 2021-10-13 16:04:26 +0200 | [diff] [blame] | 302 | opt_cfg->cmd_stream_version, |
| 303 | opt_cfg->macs_per_cc, |
| 304 | opt_cfg->shram_size, |
| 305 | opt_cfg->custom_dma); |
Jonny Svärd | d1750ec | 2022-01-04 10:59:16 +0100 | [diff] [blame] | 306 | LOG_INFO("Optimizer config. arch version: %d.%d.%d", |
Jonny Svärd | 136810f | 2021-10-13 16:04:26 +0200 | [diff] [blame] | 307 | opt_id->arch_major_rev, |
| 308 | opt_id->arch_minor_rev, |
| 309 | opt_id->arch_patch_rev); |
Jonny Svärd | d1750ec | 2022-01-04 10:59:16 +0100 | [diff] [blame] | 310 | LOG_INFO("Ethos-U config. product=%d, cmd_stream_version=%d, macs_per_cc=%d, shram_size=%d, custom_dma=%d", |
| 311 | hw_cfg.product, |
Jonny Svärd | 136810f | 2021-10-13 16:04:26 +0200 | [diff] [blame] | 312 | hw_cfg.cmd_stream_version, |
| 313 | hw_cfg.macs_per_cc, |
| 314 | hw_cfg.shram_size, |
| 315 | hw_cfg.custom_dma); |
Jonny Svärd | d1750ec | 2022-01-04 10:59:16 +0100 | [diff] [blame] | 316 | LOG_INFO("Ethos-U. arch version=%d.%d.%d", hw_id.arch_major_rev, hw_id.arch_minor_rev, hw_id.arch_patch_rev); |
Jonny Svärd | 136810f | 2021-10-13 16:04:26 +0200 | [diff] [blame] | 317 | |
| 318 | if (opt_cfg->word != hw_cfg.word) |
| 319 | { |
Jonny Svärd | d1750ec | 2022-01-04 10:59:16 +0100 | [diff] [blame] | 320 | if (hw_cfg.product != opt_cfg->product) |
| 321 | { |
| 322 | LOG_ERR("NPU config mismatch. npu.product=%d, optimizer.product=%d", hw_cfg.product, opt_cfg->product); |
| 323 | ret = false; |
| 324 | } |
| 325 | |
Jonny Svärd | 136810f | 2021-10-13 16:04:26 +0200 | [diff] [blame] | 326 | if (hw_cfg.macs_per_cc != opt_cfg->macs_per_cc) |
| 327 | { |
Kristofer Jonsson | 1975b8d | 2021-11-26 16:15:44 +0100 | [diff] [blame] | 328 | LOG_ERR("NPU config mismatch. npu.macs_per_cc=%d, optimizer.macs_per_cc=%d", |
Jonny Svärd | 136810f | 2021-10-13 16:04:26 +0200 | [diff] [blame] | 329 | hw_cfg.macs_per_cc, |
| 330 | opt_cfg->macs_per_cc); |
| 331 | ret = false; |
| 332 | } |
| 333 | |
Jonny Svärd | 136810f | 2021-10-13 16:04:26 +0200 | [diff] [blame] | 334 | if (hw_cfg.cmd_stream_version != opt_cfg->cmd_stream_version) |
| 335 | { |
Kristofer Jonsson | 1975b8d | 2021-11-26 16:15:44 +0100 | [diff] [blame] | 336 | LOG_ERR("NPU config mismatch. npu.cmd_stream_version=%d, optimizer.cmd_stream_version=%d", |
Jonny Svärd | 136810f | 2021-10-13 16:04:26 +0200 | [diff] [blame] | 337 | hw_cfg.cmd_stream_version, |
| 338 | opt_cfg->cmd_stream_version); |
| 339 | ret = false; |
| 340 | } |
| 341 | |
| 342 | if (!hw_cfg.custom_dma && opt_cfg->custom_dma) |
| 343 | { |
Kristofer Jonsson | 1975b8d | 2021-11-26 16:15:44 +0100 | [diff] [blame] | 344 | LOG_ERR("NPU config mismatch. npu.custom_dma=%d, optimizer.custom_dma=%d", |
Jonny Svärd | 136810f | 2021-10-13 16:04:26 +0200 | [diff] [blame] | 345 | hw_cfg.custom_dma, |
| 346 | opt_cfg->custom_dma); |
| 347 | ret = false; |
| 348 | } |
| 349 | } |
| 350 | |
| 351 | if ((hw_id.arch_major_rev != opt_id->arch_major_rev) || (hw_id.arch_minor_rev < opt_id->arch_minor_rev)) |
| 352 | { |
Kristofer Jonsson | 1975b8d | 2021-11-26 16:15:44 +0100 | [diff] [blame] | 353 | LOG_ERR("NPU arch mismatch. npu.arch=%d.%d.%d, optimizer.arch=%d.%d.%d", |
Jonny Svärd | 136810f | 2021-10-13 16:04:26 +0200 | [diff] [blame] | 354 | hw_id.arch_major_rev, |
| 355 | hw_id.arch_minor_rev, |
| 356 | hw_id.arch_patch_rev, |
| 357 | opt_id->arch_major_rev, |
| 358 | opt_id->arch_minor_rev, |
| 359 | opt_id->arch_patch_rev); |
| 360 | ret = false; |
| 361 | } |
| 362 | |
| 363 | return ret; |
| 364 | } |